[namastex888]

The genie UI, council-ratified Model B: the wish is the workspace, each wish hires a crew of agents shown as their real terminals (dash pattern — render THE agent, no abstraction), with a wish-scoped group chat where read-only ACP chat faces collaborate. Full design + evidence: .genie/brainstorms/genie-ui/DESIGN.md (digest-stamped SHIP), .genie/wishes/genie-ui/WISH.md. New package: packages/genie-ui.

Groups (all SHIP — acceptance + quality + Fable final gate)

• G1 shell floor — node-runtime PTY server (bun builds, node runs; bun's node-pty onData is dead — 40454-vs-0 isolated, regression-guarded), vanilla xterm client (tabs/splits/maximize), salvaged dash TerminalMirror replay, loopback+Origin-guarded ws, gates extended to cover packages/**.
• G2 genie lane — wishes left-menu + hire roster + worktreeFor (reuses genie launch group worktrees, never mints); runtime-adaptive read-only sqlite (node:sqlite server / bun:sqlite tests), proven on 25 real wishes.
• G3 chat + ACP backend — separable chat-backend (one lazy read-only ClientSideConnection per hired agent, @-mention-only, named fail-loud events) behind the isolation wall; capability-table badges (shared-memory = Hermes only). R1 ssh-ACP proven live (hermes acp → "PONG", rlmx acp transport over ssh localhost); Hermes two-faces state.db bridging demonstrated.
• G4 — residue confirmed clean, two-faces contract doc (in .docs-vendor submodule).

Verification

• 54 package tests; bun run check at the pre-existing 4-failure agent-sync baseline (zero genie-ui failures).
• Final gate booted the composed server under node and drove PTY panes + lane + chat concurrently over one ws; all four isolation walls verified greppable; Origin guard held live (401 cross-origin); no chat-driven command injection.

Merge notes

• Do not include a .docs-vendor pointer bump — the docs branch docs/genie-ui-two-faces (submodule commit b8942eb) must be pushed + PR'd to automagik-dev/docs first; recursive-submodule CI would break on an unmerged SHA. Bump the pointer after that merges.
• Follow-ups (MINOR, non-blocking): AC2 "PTY spawns on tab-open" ships as eager startAll() (record or refine); conductor auto-advance is the next wish (register the blocks edge then).
• Manual QA (no browser on the build box): browser split/maximize, reload-replay, per-pane badges, @hermes chat round-trip, non-mutation spot check — full checklist in the final-gate evidence.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4f1884e6-69e3-48b6-a319-42c0f7871cb8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch wish/genie-ui

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​xterm/​addon-fit@​0.10.0
	@​types/​ws@​8.18.1
	@​xterm/​headless@​5.5.0
	@​xterm/​addon-serialize@​0.13.0
	@​xterm/​addon-clipboard@​0.2.0
	@​homebridge/​node-pty-prebuilt-multiarch@​0.13.1
	@​agentclientprotocol/​sdk@​0.26.0
	@​xterm/​xterm@​5.5.0
	ws@​8.21.1

View full report

[gemini-code-assist]

Code Review

This pull request introduces packages/genie-ui, a browser-served, PTY-faithful terminal UI that integrates a fleet of coding agents with genie's wish and board state, alongside a wish-scoped inter-agent group chat. The implementation features a Node-based PTY server, a vanilla TypeScript client, a read-only database layer for wish contexts, and an isolated ACP-based chat backend. The review feedback highlights several critical robustness improvements: preventing cross-talk of active chat streams across different wishes in the UI, allowing failed agent faces to self-heal and recreate on subsequent mentions, wrapping PTY spawning in a try-catch block to prevent server crashes from missing directories, and defensively guarding ResizeObserver entries against empty lists.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

There is a potential cross-talk/leakage bug where active streams in this.live are shared across all wishes. Since this.live is a single map, applyEvent and addLine modify it without checking if the event or line belongs to the currently active wish. This can cause in-flight streams from other wishes to render in the active wish's chat log. Guarding these updates with wish === this.wish prevents this cross-talk.

Suggested change

	addLine(line: ChatLine): void {
	const kind = line.from === 'human' ? 'human' : 'agent';
	this.commit(line.wish, { from: line.from, text: line.text, kind });
	if (kind === 'agent') this.live.delete(line.from); // committed → drop its live bubble
	if (line.wish === this.wish) this.render();
	}
	/** A streamed chat event: a chunk to a live bubble, or a NAMED fail-loud system line (D9). */
	applyEvent(wish: string, event: ChatEventWire): void {
	if (event.kind === 'message-chunk') this.live.set(event.agentId, (this.live.get(event.agentId) ?? '') + event.text);
	else if (event.kind === 'spawn-failed' || event.kind === 'delivery-failed')
	this.commit(wish, { from: event.agentId, text: event.message, kind: 'error' });
	// reply-done needs no action here — the committed line arrives as a chat-message.
	if (wish === this.wish) this.render();
	}
	addLine(line: ChatLine): void {
	const kind = line.from === 'human' ? 'human' : 'agent';
	this.commit(line.wish, { from: line.from, text: line.text, kind });
	if (kind === 'agent' && line.wish === this.wish) this.live.delete(line.from); // committed → drop its live bubble
	if (line.wish === this.wish) this.render();
	}
	/** A streamed chat event: a chunk to a live bubble, or a NAMED fail-loud system line (D9). */
	applyEvent(wish: string, event: ChatEventWire): void {
	if (event.kind === 'message-chunk' && wish === this.wish) this.live.set(event.agentId, (this.live.get(event.agentId) ?? '') + event.text);
	else if (event.kind === 'spawn-failed' || event.kind === 'delivery-failed')
	this.commit(wish, { from: event.agentId, text: event.message, kind: 'error' });
	// reply-done needs no action here — the committed line arrives as a chat-message.
	if (wish === this.wish) this.render();
	}

[gemini-code-assist]

Once face.failed is set to true, any future @mention to that agent will silently do nothing because deliverMessage returns early without attempting to recreate the face. Deleting the face from this.faces on failure allows a fresh process to be spawned on the next mention, enabling self-healing and recovery from transient crashes or disconnections.

  private onChildDown(face: AgentFace, spawnMessage: string): void {
    if (face.failed) return;
    if (face.conn) {
      face.failed = true;
      this.faces.delete(face.reg.agentId); // Allow recreation on next message
      this.dispatch({
        type: 'delivery-failed',
        agentId: face.reg.agentId,
        message: '@' + face.reg.agentId + ' disconnected',
      });
    } else {
      this.failFace(face, spawnMessage);
    }
  }

  private failFace(face: AgentFace, message: string): void {
    if (face.failed) return; // idempotency: one child-down + one handshake-catch must emit ONE spawn-failed
    face.failed = true;
    face.child?.kill('SIGKILL');
    this.faces.delete(face.reg.agentId); // Allow recreation on next message
    this.dispatch({ type: 'spawn-failed', agentId: face.reg.agentId, harness: face.reg.harness, message });
  }

[gemini-code-assist]

pty.spawn throws synchronously if the cwd directory does not exist or is inaccessible (e.g., if a worktree was deleted). Wrapping it in a try-catch block prevents the entire server from crashing and allows the error to be written directly to the terminal mirror so the user is informed of the failure.

  start(): void {
    if (this.proc) return; // already running
    // Fresh screen on (re)start: drop the previous mirror so replay never shows
    // pre-restart content (the sync equivalent of fresh's 'buffer = ""').
    this.mirror.dispose();
    this.mirror = new TerminalMirror(this.cols, this.rows);
    const env = { ...process.env, ...this.spec.env } as Record<string, string>;
    try {
      this.proc = pty.spawn(this.spec.command, this.spec.args, {
        name: env.TERM || 'xterm-256color',
        cols: this.cols,
        rows: this.rows,
        cwd: this.spec.cwd,
        env,
      });
      this.status = 'running';
      this.lastExitCode = null;

      this.proc.onData((data) => {
        this.mirror.write(data);
        this.emit('data', data);
      });

      this.proc.onExit(({ exitCode }) => {
        this.status = 'exited';
        this.lastExitCode = exitCode;
        this.proc = null;
        // Emit `status:exited` BEFORE `exit`: restart() listens on `exit` and calls
        // start() synchronously, which emits `status:running`. Emitting status first
        // keeps the observable sequence honest (exited -> running), never reversed.
        this.emit('status', this.status);
        this.emit('exit', exitCode);
      });

      this.emit('status', this.status);
    } catch (err) {
      this.status = 'exited';
      this.lastExitCode = -1;
      this.proc = null;
      this.mirror.write('Error spawning PTY: ' + (err as Error).message + '\r\n');
      this.emit('status', this.status);
      this.emit('exit', -1);
    }
  }

[gemini-code-assist]

In some environments or browsers, ResizeObserver can occasionally fire with an empty entries list. Adding a defensive guard for entries[0] prevents potential runtime errors.

Suggested change

	new ResizeObserver((entries) => {
	this.scheduler.onResize(entries[0].contentRect.height);
	}).observe(this.mount);
	new ResizeObserver((entries) => {
	if (entries[0]) this.scheduler.onResize(entries[0].contentRect.height);
	}).observe(this.mount);

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 332f1e51ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Trim trailing punctuation from mention IDs

When a user writes a normal sentence like please ask @codex., this regex captures codex. as the agent id. ChatRoom then looks up that exact id, treats it as an unknown mention, and silently skips delivery, which is especially confusing because the @-mention-only path intentionally does not surface unknown mentions as errors.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Do not swallow retries after a chat face fails

After a missing adapter, unlaunched worktree, or later disconnect marks face.failed, any subsequent @mention to that rostered agent reaches this return without emitting another spawn-failed/delivery-failed event or attempting a respawn. The human line is still recorded, so retries after fixing PATH or restarting the adapter appear as silence in the drawer.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Hide the terminal when a selected wish has no panes

When the operator selects a wish that has no matching PaneInfo.wishId entries, firstVisible remains null, all tabs are hidden, but the LayoutManager keeps rendering the previously active terminal. Since the drawer and context now point at the newly selected wish, this can leave the user typing into an unrelated agent shell under the wrong wish context; clear the active layout or render an empty state in this branch.

Useful? React with 👍 / 👎.