[namastex888]

Wish: skills-fable5-revamp

Revamps all 17 genie skills to the Fable 5 standard and adds v4 legacy trash-cleaning to the installer/updater.

What changed

• All 17 skills/*/SKILL.md rewritten: lean always-loaded bodies (genie surface 4,185 → 1,385 lines), trigger-focused descriptions, bulk extracted to on-demand sibling files (refine/prompts/optimizer.md, genie-hacks/references/, pm/references/, report/references/).
• Re-grounded in the live v5 zero-daemon CLI: 118 dead-command references across 13 files fixed at the root; all 13 skills-lint:ignore markers removed — bun run skills:lint now scans everything and passes on merit.
• Frozen contracts preserved verbatim (template cp rule, wishes:lint gate, task linkage, SHIP/FIX-FIRST/BLOCKED vocabulary, reviewer≠engineer, session-close outcome words) — independently audited.
• G8 (feat(cli)): new legacy-v4.ts shared manifest + detectV4Install()/cleanupV4() — content-marker-gated removal of the stale ~/.claude/rules/genie-orchestration.md (backup-first, logged, idempotent), .orphaned_at-gated automagik/genie/4.* cache cleanup; wired into a recreated thin genie install finisher (bootstrap handoff restored, --skip-v4-cleanup) and guarded post-delivery in genie update; uninstall.ts consumes the same manifest. 16 new pgserve-free tests.

Evidence

• 7 execution groups, each independently reviewed; G7 system verification: all 10 success criteria PASS — see .genie/wishes/skills-fable5-revamp/verification.md.
• Combined genie+omni surface: 5,514 → 2,016 lines (−63.4%).
• Gates on this branch (also enforced by pre-push): tsc --noEmit, biome check . (111 files), knip, skills:lint (28 files), wishes:lint, bun test src/genie-commands/ 144 pass/0 fail, bash -n install.sh.
• Zero file renames/deletions; companion omni PR carries the plugin surfaces.

🤖 Generated with Claude Code

https://claude.ai/code/session_014SwFHxrsQVdwG32ChnsKku

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b71af9ac-7b4e-4e3c-9437-02680bf1eb50

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch wish/skills-fable5-revamp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request implements a comprehensive Fable 5 revamp of all Genie and Omni skills, reducing always-loaded prompt lines by over 60% and eliminating 118 dead daemon-era CLI references. It also introduces a robust v4 legacy cleanup mechanism to remove stale global rules and orphaned plugin caches with backup and logging, wired into both the installation and update flows. Feedback on the changes highlights a potential crash in the v4 detection logic if the plugin cache directory is unreadable or is not a directory, which should be wrapped in a try-catch block to ensure graceful degradation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

If cacheRoot exists but is not a directory (e.g., it is a file) or is not readable due to permission restrictions, readdirSync will throw an error (such as ENOTDIR or EACCES). Since detectV4Install is called during the installation finisher without a surrounding try-catch block, this can crash the entire installation process. Wrapping the directory reading in a try-catch block ensures the installer degrades gracefully in restricted environments.

  if (existsSync(cacheRoot)) {
    try {
      for (const entry of readdirSync(cacheRoot, { withFileTypes: true })) {
        // isDirectory() is false for symlinks: never follow a link out of the cache.
        if (!entry.isDirectory()) continue;
        if (!entry.name.startsWith(V4_LEGACY_MANIFEST.v4CacheVersionPrefix)) continue;
        const dirPath = join(cacheRoot, entry.name);
        cacheDirs.push({
          path: dirPath,
          version: entry.name,
          orphaned: existsSync(join(dirPath, V4_LEGACY_MANIFEST.orphanMarkerFile)),
        });
      }
    } catch {
      // Gracefully ignore reading errors (e.g., permission denied or ENOTDIR)
    }
  }

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af81783b49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Run cleanup from the swapped-in binary

When a host upgrades to this release from any version before this patch, the running genie update process is still the old binary, so this newly added in-process call is not present and cannot execute; the only fresh-binary exec later in the flow is the --version probe in runVerifyProbe. That means the v4 rules/cache relics remain on the primary upgrade path until a later update or manual genie install, so invoke the freshly swapped binary's finisher (or add a startup cleanup path) instead of relying only on code in the updater process.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Guard cache-root reads before cleanup

If ~/.claude/plugins/cache/automagik/genie exists but is a regular file or an unreadable directory, readdirSync throws here before cleanupV4 reaches its per-relic try/catch handling. In that home-directory state, a direct genie install exits with an error and the installer handoff reports the finisher failed instead of still cleaning the rules file or degrading gracefully, so check that the cache root is a readable directory (or catch this read) before iterating it.

Useful? React with 👍 / 👎.