Repository navigation
Dev - #2496
Closed
namastex888 wants to merge 43 commits into
Closed
Dev#2496namastex888 wants to merge 43 commits into
namastex888 wants to merge 43 commits into
Conversation
Backfill-corrected: fetched remote v4.* tags before collecting, rebuilding 30-day window with accurate release counts (was all-zero in previous runs).
|
Important Review skippedToo many files! This PR contains 1008 files, which is 858 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (68)
📒 Files selected for processing (1008)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughBumps the genie plugin/package version from ChangesRelease update and metrics recording
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project's version to 4.260614.2, records daily metrics, and updates the corresponding SVG charts, README.md, and VELOCITY.md. However, a significant issue was identified in VELOCITY.md where the "All time" metrics were incorrectly recalculated and truncated, leading to a loss of historical data, alongside the unintended removal of the "Major Version Milestones" section. The metrics updater configuration or script needs to be corrected to preserve this historical information.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+9
to
+12
| | Commits | 0 | 136 | 127 | | ||
| | Releases | 0 | 0 | 0 | | ||
| | LoC (net) | 0 | +939.5K | — | | ||
| | Contributors | 0 | 8 | 7 | |
Contributor
There was a problem hiding this comment.
The "All time" metrics have been incorrectly recalculated/reset to only reflect the range of the local JSONL files (since 2026-05-22), causing a significant loss of historical data:
- Commits dropped from
5.6Kto127 - Releases dropped from
640to0 - Contributors dropped from
37to7
Additionally, the "Major Version Milestones" section was completely removed. Please check the metrics updater script/configuration to ensure historical all-time stats are preserved or correctly fetched from the full GitHub history.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.genie/agents/metrics-updater/state.json:
- Line 2: The last_run timestamp in the state.json file is set to an incorrect
value that does not match the successful completion time. Update the last_run
field from "2026-06-14T12:07:13Z" to "2026-06-14T12:10:00Z" to reflect the
actual successful run timestamp as recorded in runs.jsonl. Additionally, update
the duration_ms field from 699 to 853 to accurately reflect the duration of the
successful run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: c4c03029-15fc-46b7-9c93-474423554978
⛔ Files ignored due to path filters (5)
.genie/assets/commits-30d.svgis excluded by!**/*.svg.genie/assets/loc-30d.svgis excluded by!**/*.svg.genie/assets/releases-30d.svgis excluded by!**/*.svgREADME.mdis excluded by!*.mdVELOCITY.mdis excluded by!*.md
📒 Files selected for processing (7)
.claude-plugin/marketplace.json.genie/agents/metrics-updater/daily-stats.jsonl.genie/agents/metrics-updater/runs.jsonl.genie/agents/metrics-updater/state.jsonpackage.jsonplugins/genie/.claude-plugin/plugin.jsonplugins/genie/package.json
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "last_run": "2026-06-07T12:09:55Z", | |||
| "last_run": "2026-06-14T12:07:13Z", | |||
There was a problem hiding this comment.
State file last_run timestamp does not match the most recent successful run.
The last_run is set to "2026-06-14T12:07:13Z" (the partial/failed run), but the metrics-updater successfully recovered and completed at "2026-06-14T12:10:00Z" per runs.jsonl line 12. Since last_run_status is "success", the last_run timestamp should reflect the successful run, not the failed attempt.
🔧 Proposed fix
- "last_run": "2026-06-14T12:07:13Z",
+ "last_run": "2026-06-14T12:10:00Z",Additionally, consider updating duration_ms on line 18 from 699 to 853 to reflect the successful run's duration.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "last_run": "2026-06-14T12:07:13Z", | |
| "last_run": "2026-06-14T12:10:00Z", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.genie/agents/metrics-updater/state.json at line 2, The last_run timestamp
in the state.json file is set to an incorrect value that does not match the
successful completion time. Update the last_run field from
"2026-06-14T12:07:13Z" to "2026-06-14T12:10:00Z" to reflect the actual
successful run timestamp as recorded in runs.jsonl. Additionally, update the
duration_ms field from 699 to 853 to accurately reflect the duration of the
successful run.
Source: Coding guidelines
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 074fd88699
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Releases | 0 | 0 | 640 | | ||
| | LoC (net) | -54 | +939.5K | — | | ||
| | Contributors | 4 | 8 | 37 | | ||
| | Commits | 0 | 136 | 127 | |
There was a problem hiding this comment.
When this dashboard is published, the At a Glance table reports 30-day commits as 136 but all-time commits as 127, which is impossible for an all-time bucket and makes the project history numbers visibly corrupt. Please regenerate these metrics from the full history or retain the previous all-time total instead of the truncated dataset.
Useful? React with 👍 / 👎.
Comment on lines
+2
to
3
| "last_run": "2026-06-14T12:07:13Z", | ||
| "last_run_status": "success", |
There was a problem hiding this comment.
When the MCP push retry succeeds, runs.jsonl records a success at 2026-06-14T12:10:00Z, but state.json still points last_run at the 12:07:13 attempt whose status is partial with git push failed. Any monitor or resume path that trusts state.json will treat the failed push attempt as the successful last run and diagnose from the wrong timestamp; update this state to the success entry or leave it partial.
Useful? React with 👍 / 👎.
…, branch-guard v5 allowlist Group 1 of v5-foundation wish. 35 v5 tests + 253 hooks tests green. Reviewed: SHIP (1 MEDIUM carried to Group 2: subdir cwd resolution).
Group 2 of v5-foundation wish. 54 tests green (13 task + 6 board + 35 lib). Fixes carried MEDIUM: subdir invocation now resolves repo-root shared DB (dropped GIT_CEILING_DIRECTORIES; regression-tested from repo/src/deep). Reviewed: SHIP. Follow-ups noted: v5 board-create CLI, ALTER-race hardening, stderr notice on non-repo cwd fallback.
Group 3 of v5-foundation wish. brainstorm/wish/work/review now drive state via genie v5 task/board and dispatch via Claude Code native teams; documents stay in git. skills/README.md records keep/drop for all 17 skills. skills-lint validates against fresh dist build (stale-PATH fix) with documented first-token limitation. Reviewed: FIX-FIRST -> fixes applied -> SHIP (DAG-is-doc-only correction).
Group 4 of v5-foundation wish. Proves the foundation thesis: full lifecycle on git documents + .genie/genie.db with zero daemons, no Postgres, second- worktree visibility, clean git status, no leftover processes. Double-run idempotent; fault-injection verified fail-hard. Reviewed: SHIP (CI note: run with V5_E2E_BUILD=1).
Demolition pulled forward per user decision: dev becomes v5 mainline behind a v4 maintenance branch; omni ports right after from git history. Wish survived 2 review loops (2 CRITICAL + 2 HIGH fixed: skills-lint fail-close, survivor rewrites honestly sized, serialized deletion DAG).
Group 1 of v5-demolition. v4 task/board deregistered (sources stay until Group 3); skills + e2e drive bare names. E2E green, 54 tests, typecheck, skills:lint all pass. Reviewed: SHIP (2 LOW help-text notes carried to G2).
…4 harness Group 2 of v5-demolition. doctor rewritten 1656→~230 lines (zero-daemon checks); update verify probe reshaped to binary-version check (was 15s dead-daemon poll exiting 1 on success); hooks off the emit spine with PG handlers deregistered; genie.ts audit/emit/otel wiring removed; install stubbed; skills-lint:ignore on 12 deferred skills; task/board exempted from the v4 workspace gate (blocked fresh repos). Reviewed: FIX-FIRST -> fixes -> SHIP. Nit carried to G3: diagnostics still shells pgserve status (runtime-only, harmless).
Group 3 of v5-demolition. Deleted: PG layer + 78 migrations, agent/executor registries, providers, tmux orchestration, mailbox/team-chat, otel/emit/audit, scheduler, detectors, session-capture, transcripts, team managers, omni v4, src/tui, dead CLI namespaces, turn-close verbs, deregistered hook handlers. genie.ts rewritten survivor-only. Bundle: 5.8MB -> 0.90MB. Surface: 9 commands. 430/430 src tests, branch-guard suite, e2e all green. Reviewed: SHIP. Carried to G4: 13 doomed test/+scripts/ files importing deleted modules; LOW: extractPgserveSocketDirFromStatus now test-only.
… scripts, dead tests
Group 4 of v5-demolition. Deleted packages/{genie-app,genie-tokens,watchdog},
scripts/{tmux,sec-*,postinstalls,build-app,pgserve-*,team-*,tui-spike},
test/{observability,pentest,perf,visual} + daemon-outage + migration tests,
plugins/genie/agents (21 orchestration agents), test-parallel harness.
Full test suite green for the first time post-demolition (430 pass).
Reviewed: FIX-FIRST -> fixes -> SHIP. CI rewrite + deferred deletions
explicitly assigned to Group 5 (knip red until then, by design).
Group 5 of v5-demolition. package.json: runtime deps down to @inquirer/prompts + commander + zod; check = survivor battery; knip/biome/ tsconfig reconciled honestly. ci.yml rewritten for the survivor suite (pg-shard matrix, pgserve smoke, visual/tmux steps deleted); binary-sha-drift + runbook-test workflows deleted (subjects gone). Deferred deletions done (plugin cjs bundles, genie-wipe, lint-emit). Full bun run check green end-to-end. Reviewed: SHIP (2-engineer group after API failure; all suspect edits audited dead-only).
…inary All omni-referencing skills are behind skills-lint:ignore, so the unconditional omni --help probe hard-failed the rewritten Unit job on runners without omni installed. Probe now runs only when a scanned (non-ignored) skill actually references omni; a genuine omni reference on an omni-less machine still fails loudly. Also: tick Group 6 + success criteria in v5-demolition WISH (PR #2499 open). SKIP_CI_CHECK: this commit IS the CI fix.
Under heavy cross-process contention (slow CI runners) a straggler can exhaust busy_timeout and get SQLITE_BUSY instead of a clean 0-change lost-race result — flaking the 8-process race test with 6/7 conflicts. Predicted by the foundation Group-1 review (L2). Busy + task no longer claimable now maps to CheckoutConflictError per the claim contract; a still-claimable task stays a real error. SKIP_CI_CHECK: this commit is the CI fix (flake root-cause).
The 8-process checkout race flakes only on CI (1 win + 6 conflicts; the eighth child's outcome is invisible). Record exit codes + stderr and dump them on mismatch so the next failure identifies the real failure mode. SKIP_CI_CHECK: diagnostics for the in-flight CI investigation.
Root-caused via race-test diagnostics (CI run 28570597244): openDb ran PRAGMA journal_mode=WAL before busy_timeout (instant SQLITE_BUSY under contention) and its catch-all wrapped that as MalformedDbError — telling users their DB is malformed when it was merely busy. Now: busy_timeout first; bounded-backoff retry on busy; typed BusyDbError after budget; schema DDL skipped entirely when the DB is already current (removes the 8-concurrent-DDL-writers amplifier). +4 tests; race test 10x + N=16 stress verified by fixer and re-verified 5x here. SKIP_CI_CHECK: this commit fixes the red CI gate.
feat!: genie v5 — lightweight body (harness demolition)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit