Skip to content

test(spawn): skip legacy id=name tests pending retire-session-names #175 #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
namastex888 merged 1 commit into from
May 4, 2026
Merged

test(spawn): skip legacy id=name tests pending retire-session-names #175 #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/__tests__/tui-spawn-dx.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ function stubRandomUuid(values: string[]): () => void {
// Suite
// ---------------------------------------------------------------------------

describe.skipIf(!DB_AVAILABLE)('tui-spawn-dx integration (Group 8)', () => {
describe.skip('tui-spawn-dx integration (Group 8) — TODO retire-session-names #175: rewrite for UUID-id', () => {

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While skipping this main integration suite is necessary to unblock CI, the pickParallelShortId cascade suite at line 520 also appears to rely on non-UUID agents.id values (e.g., 'alice', 'alice-dead') in its setup via registry.register. These will likely fail the agents_id_shape_check constraint introduced in migration 061. You should consider skipping that suite as well to ensure the CI is fully unblocked.

let cleanupSchema: () => Promise<void>;
let tempClaudeDir: string;
let savedClaudeConfigDir: string | undefined;
Expand Down
3 changes: 2 additions & 1 deletion src/term-commands/agents.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,8 @@ describe.skipIf(!DB_AVAILABLE)('spawn state machine', () => {
const alwaysAlive = async () => true;
const alwaysDead = async () => false;

describe('resolveSpawnIdentity', () => {
describe.skip('resolveSpawnIdentity', () => {

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While skipping resolveSpawnIdentity is correct, other suites in this file such as pickParallelShortId (line 767) and findDeadResumable (line 821) also rely on non-UUID agents.id values (e.g., 'alice-dead') in their setup via seedCanonical. These will likely fail the agents_id_shape_check constraint from migration 061. It's recommended to skip those suites as well to fully unblock the CI.

// TODO retire-session-names #175: rewrite tests for UUID-id contract
test('branch: no row → create canonical (id=<name>, fresh UUID)', async () => {
const team = `team-no-row-${Date.now()}`;
const uuids = ['11111111-2222-3333-4444-555555555555'];
Expand Down
Loading