[namastex888]

Summary

After PR #1627 (generateWorkerId returns UUID) merged, every fresh dispatch hits a NEW spot of the same agents.id UUID assumption:

PostgresError: invalid input syntax for type uuid: "engineer-4-eac7"

resolveSpawnIdentity (src/term-commands/agents.ts:2330) runs:

SELECT id, pane_id, team FROM agents WHERE id = ${name} LIMIT 1

with the role-name string, but agents.id is now UUID-only.

Fix

Add UUID-regex guard at function entry. Non-UUID names skip the lookup and return a fresh canonical immediately. UUID-keyed lookups still flow through the original code path.

if (!/^[0-9a-f]{8}-...-[0-9a-f]{12}$/i.test(name)) {
  return { kind: 'canonical', workerId: uuidFactory(), sessionUuid: uuidFactory() };
}

Companion to PRs #1626 + #1627

• fix(dispatch): unique role suffix to unblock wave dispatch collisions #1626 fixed dispatch role-collision (engineer-3 colliding across wishes)
• fix(spawn): generateWorkerId returns uuid for agents_id_shape_check #1627 fixed generateWorkerId to return UUID
• fix(spawn): guard resolveSpawnIdentity against non-uuid names #1628 (this) fixes resolveSpawnIdentity — same UUID-coercion blind spot in a different code path

After all three merge, spawn pipeline is fully unblocked end-to-end post-migration-061.

Validation

• bun run typecheck clean

Test plan

• After merge: genie work autopg-distribution-cutover dispatches G4 without invalid input syntax error
• After merge: genie spawn engineer --team genie produces fresh canonical row with UUID id
• Existing UUID-keyed lookups still work (no regression)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f4d24b4f-2314-4488-a47f-618fd29031ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch wish/spawn-identity-uuid-guard

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request updates the resolveSpawnIdentity function to handle non-UUID agent names by returning a fresh canonical identity, preventing database lookup failures following a schema migration. The review feedback suggests using the existing UUID_REGEX constant for better maintainability and points out a potential issue where parallel ID generation might still violate UUID constraints in the database.

[gemini-code-assist]

Use the existing UUID_REGEX constant (defined at line 2258) instead of duplicating the regex literal. This improves maintainability and ensures consistency across the module.

Additionally, while this guard prevents crashes for role-based names (like "engineer"), the parallel spawn logic later in this function (line 2413) still constructs workerId as ${name}-${shortId}. If agents.id is a UUID type in Postgres, those parallel IDs will still cause invalid input syntax for type uuid errors. You should consider updating the parallel ID generation to ensure it always produces a valid UUID.

  if (!UUID_REGEX.test(name)) {

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8886e5f073

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Preserve role-scoped identity for non-UUID spawn names

Returning early for any non-UUID name bypasses all existing canonical lookup/liveness logic and always mints a brand-new workerId, so repeated genie spawn <role> calls no longer correlate with the same role identity. In this code path, identity.workerId is later assigned to effectiveRole (handleWorkerSpawn), which means downstream registration/lookup uses a fresh UUID instead of the requested role name, breaking the intended canonical/parallel decision path and making role-based resume/dispatch behavior diverge for normal role names.

Useful? React with 👍 / 👎.