Skip to content

fix(spawn): remove hardcoded 'genie' default from --team #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
namastex888 merged 1 commit into from
Apr 16, 2026
Merged

fix(spawn): remove hardcoded 'genie' default from --team #1154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/term-commands/agent/spawn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export function registerAgentSpawn(parent: Command): void {
.command('spawn <name>')
.description('Spawn a new agent by name (resolves from directory or built-ins)')
.option('--provider <provider>', 'Provider: claude, codex, or claude-sdk')
.option('--team <team>', 'Team name', process.env.GENIE_TEAM ?? 'genie')
.option('--team <team>', 'Team name')

@gemini-code-assist gemini-code-assist Bot Apr 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the default value here means options.team will be undefined when the flag is not provided. However, the SpawnOptions interface in src/term-commands/agents.ts (which is used to type the options argument in the action handler on line 43) currently defines team as a required string. This will likely cause a TypeScript compilation error if strictNullChecks is enabled. Please update the SpawnOptions interface to team?: string; to reflect that this property is now optional.

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align genie spawn team default with agent spawn

This change removes the implicit genie team only for genie agent spawn, but the documented top-level alias still sets .option('--team <team>', 'Team name', process.env.GENIE_TEAM ?? 'genie') in src/genie.ts (the section labeled “Top-level aliases — shortcuts for genie agent ”). As a result, genie spawn <name> and genie agent spawn <name> now behave differently, and the current-window spawn path remains unreachable for users invoking the top-level command.

Useful? React with 👍 / 👎.

.option('--model <model>', 'Model override (e.g., sonnet, opus)')
.option('--skill <skill>', 'Skill to load (optional)')
.option('--layout <layout>', 'Layout mode: mosaic (default) or vertical')
Expand Down
Loading