Repository navigation
chore: rolling promotion dev -> main - #1149
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7c13c55fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { existsSync, mkdirSync, readFileSync, renameSync, statSync, writeFileSync } from 'node:fs'; | ||
| import { join } from 'node:path'; | ||
| import { homedir } from 'node:os'; | ||
| import { basename, join, relative, resolve } from 'node:path'; |
There was a problem hiding this comment.
Include dirname and isAbsolute in the imports from node:path to enable more robust and cross-platform path handling in the subsequent logic.
| import { basename, join, relative, resolve } from 'node:path'; | |
| import { basename, dirname, isAbsolute, join, relative, resolve } from 'node:path'; |
| function assertOutsideRepo(snapshotPath: string, cwd?: string): void { | ||
| const repoRoot = resolveRepoPath(cwd); | ||
| const rel = relative(repoRoot, resolve(snapshotPath)); | ||
| const insideRepo = !rel.startsWith('..') && rel !== '' && !rel.startsWith('/'); |
There was a problem hiding this comment.
The check !rel.startsWith('/') is not cross-platform and will fail on Windows, where absolute paths start with a drive letter. This could lead to false positives when checking if a path is inside the repository. Use isAbsolute(rel) instead.
| const insideRepo = !rel.startsWith('..') && rel !== '' && !rel.startsWith('/'); | |
| const insideRepo = !isAbsolute(rel) && !rel.startsWith('..') && rel !== ''; |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 42 minutes and 48 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rolling promotion of
devintomain. Replaces #1146.