Skip to content

fix(spawn): remove --session <team> override that breaks tmux topology - #1012

Merged
namastex888 merged 1 commit into
devfrom
fix/spawn-session-override-rule
Apr 3, 2026
Merged

namastex888 merged 1 commit into
devfrom
fix/spawn-session-override-rule

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Summary

  • Remove --session <team> from council SKILL.md spawn commands — this overrides resolveSpawnTeamWindow (agents.ts:693) and creates a separate tmux session instead of using the team's configured parent session
  • Add "Spawn Session Rule" to genie-orchestration.md — agents must never pass --session when --team is set
  • Add --session prohibition to team-lead constraints — prevents AI from hallucinating --session <team> on spawn commands

Root cause

resolveSpawnTeamWindow checks sessionOverride first (line 693). When --session review-waves is passed, it skips the team config lookup entirely and creates/uses a session called review-waves — a separate session from the parent project.

Without --session, line 695 reads teamConfig.tmuxSessionName which was correctly set at team creation time from the parent session.

Test plan

  • 1818 tests pass
  • Typecheck, lint, dead-code clean
  • Verify workers land in parent session when spawned with --team only

The --session flag overrides the team config's tmuxSessionName, creating
a separate tmux session instead of using the parent session resolved at
team creation. This caused workers (reviewers, council members) to land
in isolated sessions instead of the project session.

- Remove --session <team> from council SKILL.md spawn commands
- Remove --session <team> from council member config examples
- Add "Spawn Session Rule" to genie-orchestration.md
- Add --session constraint to team-lead AGENTS.md
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Apr 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: afa505c6-915a-4b8c-bcf8-cdfa6e848aa3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/spawn-session-override-rule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@namastex888
namastex888 merged commit bd91197 into dev Apr 3, 2026
6 checks passed
@namastex888
namastex888 deleted the fix/spawn-session-override-rule branch April 10, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant