Repository navigation
fix(ci): version workflow triggers on dev with v4 prefix - #709
Conversation
- Add dev to workflow_run branches so CI on dev triggers versioning - Fix v3 → v4 prefix in Derive version step - Dev pushes trigger without requiring merge commit message - All versioning still targets dev branch and publishes as @next
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated GitHub Actions workflow trigger to execute on both Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14f77eabc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| EXISTING=$(git tag --list "v4.${TODAY}.*" | wc -l) | ||
| BUILD_NUMBER=$((EXISTING + 1)) | ||
| VERSION="3.${TODAY}.${BUILD_NUMBER}" | ||
| VERSION="4.${TODAY}.${BUILD_NUMBER}" |
There was a problem hiding this comment.
Keep derived tag major in sync with published package version
This change derives 4.YYMMDD.N in the workflow, but bun run version still generates 3.YYMMDD.N from scripts/version.ts (see git tag --list "v3..." and return 3.${datePrefix}.${n}``), and that script is what updates package.json before publish. In runs on `dev`, this will create `v4.` tags while publishing `3.` package versions, and subsequent same-day runs can attempt to publish an unchanged npm version while continuing to mint new tags.
Useful? React with 👍 / 👎.
Summary
devtoworkflow_runbranches so CI completions on dev trigger auto-versioningv3→v4prefix in the Derive version stepdevbranch and publishes to npm as@nextWhy this must target main: GitHub evaluates
workflow_runtriggers using the workflow file from the default branch. The fix ondevhas no effect untilmainhas it too.Test plan
.github/workflows/version.yml— no code changesv4.YYMMDD.Ntag createdSummary by CodeRabbit