chore: promote dev to main — skills sync fix - #624
Conversation
The skills symlink at plugins/genie/skills doesn't survive npm packaging. syncPlugin() now copies skills/ from the package root to the cache dir as a fallback.
fix: copy skills dir to plugin cache on sync
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR bumps the genie plugin version from 3.260317.1 to 3.260317.2 across multiple manifest and package files. It also adds logic to copy a top-level skills directory from the installed package into the cache during plugin synchronization. Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related PRs
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes changes from the development branch to main, including fixes for adding an initialPrompt to dispatch commands and ensuring the skills directory is correctly copied during plugin synchronization. The changes appear to correctly implement these fixes. My review includes a few suggestions for the newly added skills/genie/SKILL.md documentation to improve the clarity of command examples and prevent potential misinterpretation.
I am having trouble creating individual review comments. Click here to see my feedback.
skills/genie/SKILL.md (114)
The use of | to show alternative commands can be ambiguous and might be misinterpreted as a shell pipe, especially by an LLM. It's better to list each command on a separate line for clarity.
genie team hire <agent>
genie team fire <agent>
skills/genie/SKILL.md (116)
Similar to the hire | fire command, using | here can be confusing. Listing each command on a new line would improve readability and prevent misinterpretation.
genie team done <name>
genie team blocked <name>
genie team disband <name>
skills/genie/SKILL.md (131)
To maintain consistency and clarity across the command reference, it's best to separate these alternative commands onto their own lines.
genie kill <name>
genie stop <name>
1 participant
Changes
Summary by CodeRabbit
Chores
Bug Fixes