chore: rolling promotion dev -> main - #618
Conversation
- Update README.md with current CLI commands, team-lead flow, --wish flag, agent directory, and worktree documentation - Expand orchestration rules with full team-lead lifecycle and command set - Rewrite PM prompt to promptMode: system with XML behavioral blocks - Refine all 8 worker prompts with XML blocks (promptMode: append) - Refine all 11 council prompts with XML blocks, preserving persona inspirations as perspective framing - Sync all flat .md copies with folder AGENTS.md files
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (46)
📝 WalkthroughWalkthroughBumps plugin/package versions to 3.260316.18 and extensively restructures many plugins/genie documentation and agent specs (adds promptMode/front-matter, replaces narrative prose with tagged rubric/process blocks); deletes Changes
Sequence Diagram(s)(silently omitted — changes are primarily documentation restructuring and file updates, not a new multi-component control flow that requires a sequence diagram) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated rolling promotion from the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated rolling promotion, which includes a version bump across several configuration files. I've identified a potential issue with the new version number, 3.260316.18. According to the versioning scheme defined in scripts/version.ts (3.YYMMDD.N), this version corresponds to a future date: March 16, 2026. This suggests the versioning script may have been executed in an environment with an incorrect system clock. This can cause significant issues with package management, dependency resolution, and release tracking, as this version will be considered 'newer' than any subsequent releases for the next two years. I recommend investigating the environment where the version bump occurred and regenerating the version with the correct date.
| { | ||
| "name": "@automagik/genie", | ||
| "version": "3.260316.17", | ||
| "version": "3.260316.18", |
There was a problem hiding this comment.
The new version 3.260316.18 appears to be based on a future date (March 16, 2026), following the project's 3.YYMMDD.N versioning scheme. This likely indicates that the versioning script was run in an environment with a misconfigured system clock. Using a future-dated version can lead to problems with package managers and make release ordering confusing. It's recommended to correct the version to reflect the actual release date.
| { | ||
| "name": "genie", | ||
| "version": "3.260316.17", | ||
| "version": "3.260316.18", |
There was a problem hiding this comment.
Similar to other files in this PR, the version 3.260316.18 is based on a future date (March 16, 2026) according to the 3.YYMMDD.N scheme. This points to a systemic issue in the versioning process, likely a misconfigured system clock in the build environment. This should be corrected to ensure proper version ordering and avoid potential issues with tooling that consumes this marketplace file.
- Add missing "criteria satisfied with evidence" to docs agent done_report - Restore "Minimal tool surface" constraint to trace agent - Add required --repo flag to comparison table example
Audit found 11 CRITICAL, 17 HIGH, 6 MEDIUM severity losses from the
XML refactoring. Restores:
- Scope/authority boundary ("intermediate worker") to all 8 workers
- Trace "investigation only, always" constraint + orchestrator handoff
- <execution_mode> sections to all 10 council agents (hybrid capabilities)
- <remember> philosophical grounding to 7 council agents
- council--tracer <thinking_style> with 3 decision heuristic patterns
- council--tracer detailed APPROVE/REJECT/MODIFY conditions
- council--benchmarker full methodology (setup, measurement, tools)
- PM strategic identity and metrics-driven framing
- PM escalation chain specificity (worker→lead→PM→human)
- <related_agents> context for benchmarker, measurer, questioner
- Checklist format (- [ ]) in all council rubrics
Merge the full 740-line prompt-optimizer reference directly into the /refine SKILL.md. The 10-rule system prompt is the entry point; the full reference (type detection, anti-patterns, core patterns, examples, quality checklist) follows as the comprehensive guide. Removes plugins/genie/references/prompt-optimizer.md — no more separate file to forget to load.
Audit found 2 NON-COMPLIANT and 5 NEEDS-WORK agents. Fixes: - refactor: Add D/I/V structure to Mode 2, success_criteria, never_do sections. Define confidence levels. Was NON-COMPLIANT, now COMPLIANT. - qa: Add weighted rubric (4 dimensions), evidence_format spec, clarify AND/OR in verdict gates. Was NON-COMPLIANT, now COMPLIANT. - reviewer: Add evidence format requirement (file:line citations) - engineer: Extract success_criteria and never_do from constraints - fix: Extract success_criteria and never_do from constraints - docs: Extract success_criteria and never_do from constraints - council: Add evidence_requirements schema, strengthen constraints with actionable specifics
Both prompts were missing explicit hand-off conditions between phases. Added **Gate:** lines to each phase defining: - What must be true before the next phase starts - What to do when a gate fails (retry, escalate, stop) PM: 8 phases now have gates. Consolidated redundant commands_reference into tool_usage section. Team-lead: 8 phases now have gates with specific failure conditions (2-round limits, blocked escalation, CI requirements). All 21 agent prompts now COMPLIANT with prompt-optimizer reference.
docs: overhaul README, orchestration rules, and all agent prompts
1 participant
Rolling Promotion PR
Auto-maintained rolling promotion PR from
devtomain.Process:
ready-to-mergeadded when all checks passSummary by CodeRabbit
Chores
Documentation