Repository navigation
fix: kickoff message — genie work spawns automatically - #590
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important correction in the team kickoff message. The change ensures that the instruction provided to the 'team-lead' regarding the activation of team members is accurate, replacing an incorrect command with the correct one. This improves clarity and prevents potential confusion during the initial setup process. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects an instructional message in the kickoffPrompt for the team-lead agent. The previous message incorrectly instructed the agent to use genie spawn, while the updated message correctly states that genie work will automatically spawn the necessary agents. This is a good correction that aligns the prompt with the agent's documentation and intended workflow. I've added one suggestion to improve the readability of the long prompt string for better maintainability.
| // Spawn leader — AGENTS.md comes from the built-in resolver, all context in the initial prompt | ||
| const members = standardTeam.filter((r) => r !== 'team-lead').join(', '); | ||
| const kickoffPrompt = `Your team is "${config.name}". Repo: ${config.repo}. Branch: ${config.name}. Worktree: ${config.worktreePath}. Wish slug: ${slug}. Your team members are: ${members} (already hired, use genie spawn to activate them). Read the wish at .genie/wishes/${slug}/WISH.md and execute the full lifecycle autonomously.`; | ||
| const kickoffPrompt = `Your team is "${config.name}". Repo: ${config.repo}. Branch: ${config.name}. Worktree: ${config.worktreePath}. Wish slug: ${slug}. Your team members are: ${members} (already hired — genie work will spawn them automatically). Read the wish at .genie/wishes/${slug}/WISH.md and execute the full lifecycle autonomously.`; |
There was a problem hiding this comment.
This line is very long, which can make it difficult to read and maintain. For better readability, consider breaking this long string into an array of smaller strings and then joining them. This improves the code's clarity without altering the final prompt's content.
const kickoffPrompt = [
`Your team is "${config.name}".`,
`Repo: ${config.repo}.`,
`Branch: ${config.name}.`,
`Worktree: ${config.worktreePath}.`,
`Wish slug: ${slug}.`,
`Your team members are: ${members} (already hired — genie work will spawn them automatically).`,
`Read the wish at .genie/wishes/${slug}/WISH.md and execute the full lifecycle autonomously.`,
].join(' ');
1 participant
Was telling team-lead to 'use genie spawn to activate' — wrong, genie work does it.