Repository navigation
fix(skills): refresh all skills + orchestration rules rewrite - #565
Conversation
…arn+brain Group 1 — Orchestration Rules Rewrite: - Rewrite ORCHESTRATION_PROMPT in smart-install.js and install.sh with current CLI commands (spawn, kill, stop, ls, team create/hire/fire/disband, send, broadcast, chat, done, status, reset) - Add skill auto-invocation chain, team lifecycle, and rules sections - Remove stale genie agent spawn, genie team ensure, genie agent dashboard refs - Both files have identical orchestration content Group 2 — Kill Onboarding + Inline References: - Delete skills/onboarding/ directory entirely - Inline prompt optimizer content into skills/refine/SKILL.md - Inline design template into skills/brainstorm/SKILL.md - Inline wish template into skills/wish/SKILL.md - Remove all references/ file paths from SKILL.md files Group 5 — Learn Rewrite + Brain Update: - Rewrite skills/learn/SKILL.md: primary trigger is user correction, diagnoses which behavioral surface needs change (CLAUDE.md, AGENTS.md, SOUL.md, rules/, memory/, hooks, configs). Remove BOOTSTRAP.md ref. Connect to Claude native memory. - Update skills/brain/SKILL.md: add brain vs memory distinction (brain=context graph, memory=behavioral learnings). Add auto-install: detect notesmd-cli, offer install from https://github.com/Yakitrak/notesmd-cli
Group 3 — Core Chain Skills: - brainstorm: remove genie brainstorm crystallize, auto-invoke /review at WRS=100, suggest /council when Decisions stuck after 2+ exchanges - wish: fuzzy gate check auto-triggers /brainstorm, step 7 declares depends-on, handoff auto-invokes /review instead of suggesting /work - work: clarify as implementor skill via genie work dispatch, add local /review per group, genie send signaling, leader uses genie done (not worker), remove "no state management" confusion - review: add SHIP next-steps per context (plan→wish/work, execution→PR, PR→merge), auto-invoke /fix on FIX-FIRST, /trace for unclear root cause Group 4 — Support Skills: - council: add auto-invocation triggers (review arch decisions, brainstorm stuck decisions), document genie team hire council, add 2min timeout for full spawn, clarify lightweight=simulate vs full spawn=real agents - trace: add genie send for reporting findings, clarify spawned agent IS the tracer, /review can invoke /trace - report: document agent-browser as genie dependency, add wish criteria linking during QA, add QA failure auto-invocation chain - docs: add doc types (README, CLAUDE.md, API, architecture, JSDoc), CLAUDE.md as first-class surface, post-work suggestion - refine: verified inlined content, no remaining references/ paths Group 6 — Dream Lifecycle: - Phase 1: use genie work dispatch per group (state tracking for free), genie status/done/reset for monitoring - Phase 2: leader creates PR, reads bot comments critically, /fix valid issues, CI green required (poll, don't sleep) - Phase 3: merge to dev, spawn tester, QA loop until all criteria proven, each fix = new PR to dev - Phase 4: DREAM-REPORT.md with per-wish QA status - Remove Status: SHIPPED and sleep 5 references - Add full team lifecycle: create→execute→review→merge→QA→disband
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a significant overhaul of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive refresh of all Genie skills and a rewrite of the orchestration rules. The changes align the skills with a new three-layer architecture and the full delivery lifecycle, including a new QA loop. The documentation for all skills has been significantly updated to reflect these new, more automated workflows. The CLI command structure has also been updated.
My review focuses on the clarity and consistency of the new documentation and command structures. I've identified a minor markdown formatting issue in one of the skill documents and a potential inconsistency in the CLI command design that could be improved for better user experience. Overall, this is a substantial and well-executed refactoring that greatly improves the clarity and automation of the Genie skills framework.
| genie agent history <name> # Session history | ||
| genie agent read <name> --follow # Tail terminal output | ||
| genie agent answer <name> <choice> # Answer prompt (1-9 or text:...) |
There was a problem hiding this comment.
For consistency with other agent lifecycle commands like genie spawn and genie kill which are at the top level, consider moving history, read, and answer to the top level as well by removing the agent subcommand. This would make the CLI more uniform.
| genie agent history <name> # Session history | |
| genie agent read <name> --follow # Tail terminal output | |
| genie agent answer <name> <choice> # Answer prompt (1-9 or text:...) | |
| genie history <name> # Session history | |
| genie read <name> --follow # Tail terminal output | |
| genie answer <name> <choice> # Answer prompt (1-9 or text:...) |
| genie agent history <name> # Session history | ||
| genie agent read <name> --follow # Tail terminal output | ||
| genie agent answer <name> <choice> # Answer prompt (1-9 or text:...) |
There was a problem hiding this comment.
For consistency with other agent lifecycle commands like genie spawn and genie kill which are at the top level, consider moving history, read, and answer to the top level as well by removing the agent subcommand. This would make the CLI more uniform.
| genie agent history <name> # Session history | |
| genie agent read <name> --follow # Tail terminal output | |
| genie agent answer <name> <choice> # Answer prompt (1-9 or text:...) | |
| genie history <name> # Session history | |
| genie read <name> --follow # Tail terminal output | |
| genie answer <name> <choice> # Answer prompt (1-9 or text:...) |
| \```bash | ||
| # Command that exits 0 on success | ||
| \``` |
There was a problem hiding this comment.
There seems to be a typo in the markdown for the code block. The backticks are escaped, which will prevent the code block from rendering correctly.
| \```bash | |
| # Command that exits 0 on success | |
| \``` | |
| # Command that exits 0 on success |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b04faff7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| genie team ensure <name> # Ensure team exists (creates if needed) | ||
| genie team list # List teams | ||
| genie team delete <name> # Delete team | ||
| genie team create <name> # Create a team |
There was a problem hiding this comment.
The rewritten orchestration prompt instructs genie team create <name>, but this command now requires a repository argument and fails without it. I verified CLI semantics with bun src/genie.ts team create --help (shows --repo <path>) and bun src/genie.ts team create demo (returns required option '--repo <path>' not specified), so agents following this prompt will fail at team setup and cannot proceed with the documented lifecycle.
Useful? React with 👍 / 👎.
- Change genie agent history/read/answer to genie history/read/answer (top-level commands, not under agent namespace) in both install.sh and smart-install.js - Fix escaped backticks in wish SKILL.md template (remove backslashes) - Add --repo <path> to genie team create in both orchestration prompts (--repo is required)
1 participant
Summary
Complete refresh of all 13 genie skills and orchestration rules rewrite. Aligns everything with current CLI commands, the three-layer architecture (dispatch → skills → orchestration rules), and the full delivery lifecycle.
Changes
Orchestration Rules Rewrite (Group 1)
ORCHESTRATION_PROMPTinsmart-install.jsandinstall.shKill Onboarding + Inline References (Group 2)
skills/onboarding/—smart-install.jshandles setupprompt-optimizer.mdinto/refineSKILL.mddesign-template.mdinto/brainstormSKILL.mdwish-template.mdinto/wishSKILL.mdCore Chain (Group 3)
/brainstorm: auto-/reviewat WRS=100,/councilsuggestion when stuck/wish: auto-detect fuzzy →/brainstorm, auto-/reviewafter writing/work: local/reviewper group,genie sendsignaling,genie donetracking/review: SHIP next-step per context, auto-/fixon FIX-FIRSTSupport Skills (Group 4)
/council: auto-invocation triggers,genie team hire councildocs, timeout/trace:genie sendfor reporting, auto-invocation by/review/report:agent-browseras dependency, wish criteria linking/docs: CLAUDE.md as first-class surface, doc types, post-work suggestion/refine: inlined content, no external refsLearn + Brain (Group 5)
/learn: rewritten — diagnoses any behavioral surface, Claude native memory/brain: brain vs memory distinction, notesmd-cli auto-install offerDream (Group 6)
genie workdispatch → PR → merge to dev → QA loopStatus: SHIPPED,sleep 5)genie done/status/resetintegrationTest plan
genie agent spawn,genie worker,genie brainstorm crystallize,BOOTSTRAP,references/skills/onboarding/deletedbun run typecheckpassesbun test— 708 pass, 0 fail