Skip to content

fix(spawn): pass CWD to tmux split-window via -c flag #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
namastex888 merged 4 commits into from
Mar 14, 2026
Merged

fix(spawn): pass CWD to tmux split-window via -c flag #563

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
070bef5
Merge pull request #529 from automagik-dev/dev
namastex888 Mar 10, 2026
c02b516
fix(session): sanitize dots in tmux window names + regression tests (…
filipexyz Mar 12, 2026
239a179
chore: resolve merge conflict in session.ts (keep dev version)
Mar 14, 2026
ccd43f7
fix(spawn): pass CWD to tmux split-window via -c flag (#562)
Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/term-commands/agents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,8 @@ async function launchTmuxSpawn(ctx: SpawnCtx): Promise<void> {

let paneId: string;
try {
const splitCmd = `tmux split-window -d ${splitTarget} -P -F '#{pane_id}' ${ctx.fullCommand}`;
const cwdFlag = ctx.cwd ? `-c '${ctx.cwd}'` : '';

@gemini-code-assist gemini-code-assist Bot Mar 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The ctx.cwd variable is used to construct a shell command without proper escaping, which can lead to a command injection vulnerability. If ctx.cwd contains special shell characters like a single quote, it can break the command or allow arbitrary code execution. Please escape ctx.cwd to prevent this. A similar escaping pattern is used in src/lib/tmux.ts.

Suggested change
const cwdFlag = ctx.cwd ? `-c '${ctx.cwd}'` : '';
const cwdFlag = ctx.cwd ? `-c '${ctx.cwd.replace(/'/g, "'\\''")}'` : '';

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Escape cwd when building tmux split command

Building cwdFlag as -c '${ctx.cwd}' injects an unescaped path into a shell command passed to execSync, so any --cwd (or resolved repo path) containing a single quote will break parsing (e.g., o'connor) and can also introduce shell-injection risk if the value is attacker-controlled. This makes genie spawn fail for valid filesystem paths in those environments; use argument-based process APIs or robust shell escaping for ctx.cwd before interpolation.

Useful? React with 👍 / 👎.

const splitCmd = `tmux split-window -d ${splitTarget} ${cwdFlag} -P -F '#{pane_id}' ${ctx.fullCommand}`;
paneId = execSync(splitCmd, { encoding: 'utf-8' }).trim();
} catch (err) {
console.error(`Failed to create tmux pane: ${err instanceof Error ? err.message : 'unknown error'}`);
Expand Down
Loading