Repository navigation
refactor(skills): consolidate Genie into 14 focused workflows - #2902
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f7a3c7105
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Allow a symlinked HOME, but never follow a redirected agent home below it. | ||
| const parentMatches = | ||
| contained && realpathSync(dirname(target)) === join(realpathSync(context.home), dirname(mirrored)); | ||
| if (!parentMatches || expected === undefined || computeSkillDirDigest(target) !== expected) { |
There was a problem hiding this comment.
When another process edits or replaces a retired skill after this digest check but before renameSync, the check authorizes the old snapshot while the later rename moves the new user-owned directory out of the live skill home. This can occur during concurrent agent or manual skill edits, violating the promise that modified copies remain in place; bind the check to the directory's physical identity or reverify the parked directory and restore it on mismatch.
AGENTS.md reference: AGENTS.md:L30-L30
Useful? React with 👍 / 👎.
1f7a3c7 to
ed6028f
Compare
2 participants
What changes
Genie shipped 25 overlapping skills with repeated orchestration policy, old model-tuning instructions, and obsolete resources. This reduces the catalog to 14 distinct workflows, with domain audits loaded on demand and Orca-specific execution guidance attached to the core lifecycle.
refineaccepts only--for openaiand--for claude. The switches select prompting guidance, never a runtime model. The skill and both concise provider guides link the official GPT-6 Astra prompting guidance, OpenAI prompt engineering, Claude Fable 5.1 guide, and Claude best practices, checked 2026-09-15. Invalid/model-specific selectors stop before reading or writing input.The shared Astra/Fable agreement is to retain concrete intent, boundaries, runtime contracts, independent review, and required evidence; remove duplicated policy, fixed rituals, decorative personas, and guidance that the current runtime already supplies. A Claude Fable 5.1 coworker launched through Orca assessed every skill/resource, agreed the consolidation, implemented a disjoint scope, and independently reviewed the Astra-owned changes. Astra reviewed the Fable-owned changes. The agreement itself was refined through the
refineworkflow.Across the entire shipped
skills/tree (entrypoints, metadata, templates, and references), this reduces 42,811 words ondevto 16,263 and 291,224 bytes to 115,582 (about 62% less text). The original 25 entrypoints become 14; 72 files become 47.Every original skill
brainstormwishworkreviewfixgenierefinereportdocscouncildreamquickomnigenie-hacksarchitecturereviewarchitecture lens.code-qualityreviewcode-quality lens.dx-docsreviewDX lens anddocs.perfreviewperformance lens.qareviewtest-quality lens.repo-hygienereviewrepository-hygiene lens.supply-chainreviewsecurity/supply-chain lens.tracereportinvestigation.genie-orca-wishwishOrca mode.genie-orca-workworkOrca mode/reference.genie-orca-reviewreviewOrca mode.Resource review also removes duplicate native-surface guidance, brainstorming persona cards, obsolete Orca migration/retro scripts, and the historical fixed-percentage
skills:auditscript. Machine-consumed wish fields and both self-contained design-digest helpers remain. Metadata and distribution tests derive their inventory from the shipped tree.Upgrade behavior
The pinned skills installer does not remove retired skill names. After replacement skills are verified,
genie updatenow atomically moves previously recorded, unchanged retired directories into an owner-onlyGENIE_HOME/state-backups/skills-retirement-*tree before publishing the new install record. Edited, unverified, symlinked/redirected, and outside-home copies are preserved with a manual-review notice. An unverified replacement set in one home preserves its retired copies for manual review while other homes can converge. No verified replacement anywhere, or an archive failure, retains the previous record for retry. Cross-filesystem archive moves fail with the original intact; manual skills.sh installs without a Genie record require manual review of old names.Validation
bun install --frozen-lockfile— passes; 293 installs / 364 packages, unchanged lockfile.bun run check— all static gates pass; the final full suite reports 2,049 pass, 1 skip, and two five-second timeouts in unchanged tests (plus the timeout-killed process error). Both timed-out tests pass on a normal-settings targeted retry in 1.28 seconds total. The preceding full run passed 2,048 tests before the final three added regression cases; all 58 current installer tests pass (typecheck, Biome, Knip, skill/wish/complexity/bundle gates and full tests).npx -y skills@1.5.23 add "$PWD" --listplus inventory parity — exactly the 14 shipped skills.bash scripts/build-binary.sh --platform linux-x64-glibc— 34 MB tarball; source, staging and extracted-payload smoke/version checks pass. All 47 skill/resource files match the reviewed source bytes; compiled CLI reports5.260915.1from a neutral directory.Two existing complexity warnings remain in unchanged functions. Only the native Linux tarball was built locally; cross-platform release promotion is outside this PR.
Scope notes
This builds on the two commits from #2901 rebased onto
devand the provider-only refinement change. All changes are delivered in this new PR; no merge or release is included. The separately maintained documentation site still has older skill pages and is not changed by this repository PR; the root and shipped skill READMEs document the new routes and upgrade behavior.