chore: rolling promotion dev -> main by namastex888 · Pull Request #2750 · automagik-dev/genie

namastex888 · 2026-08-03T03:31:18Z

Rolling Promotion PR

Auto-maintained rolling promotion PR from dev to main.

Process:

This PR is automatically created and kept open
Human reviews and merges when ready
Label ready-to-merge added when all checks pass

IMPORTANT: Merge with "Create a merge commit" — NEVER squash.
Squash merging breaks history sync between dev and main,
causing the next rolling PR to show all commits again.

Human approval required for merge to production.

Summary by CodeRabbit

New Features
- Improved Pi integration detection and automatic extension synchronization.
- Uninstall now safely removes Genie-managed Pi links while preserving unrelated files and links.
- Added clearer lifecycle-busy messaging with consistent exit behavior.
Bug Fixes
- Blank Pi configuration values now fall back to valid default locations.
- Pi synchronization works when the extensions directory has not yet been created.
- Improved recovery from busy or stale lifecycle locks.
Documentation
- Updated Pi installation and synchronization guidance.
Chores
- Updated Genie components to version 5.260803.6.

Pi (verified against the real pi runtime: extensions/ is created only by package installs, never at startup): - sync + doctor detect pi from the agent dir (or pi on PATH), so a package-less pi install without agent/extensions still gets the link - genie uninstall collects the pi extension symlink (identity-checked: only links resolving into GENIE_HOME), generalizing the hermes-link collector to plugin-link - README/native-surface scope the auto-sync claim to absent-or-correct targets and route conflicts to genie doctor - two CLI-level doctor tests via the existing captureDoctor harness Lifecycle (PR #2745 follow-ups): - lifecycleBusyMessage moved to src/lib/ordered-lifecycle-leases.ts and shared by update/install/uninstall (was written three times) - busy-holder test deadlines 60ms -> 500ms (25ms poll + GC pause could collapse the loop to one attempt) - WISH.md: group/QA checkboxes ticked with sandboxed dev-tip binary QA evidence (live holder exit-2, dead-holder steal ~100ms) Declined with evidence in thread replies: ensurePluginLink symlink window (pre-existing hermes-lane tradeoff, recoverable); describe-body env capture (file convention) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(review): resolve PR #2743 review threads

PI_CODING_AGENT_DIR='' passed the ?? in resolvePiExtensionsDir and resolved the extensions dir cwd-relative; the local installer accepted whitespace-only PI_CODING_AGENT_DIR / PI_HOME the same way. Both now use the trim guard resolvePiHome already applies, with regression tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix(pi): treat empty or whitespace pi env overrides as absent

Merged via #2745 into dev; QA complete including the end-to-end host update 5.260803.1 -> 5.260803.3 (borrowed-lease converge verified). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…cle-lease chore(wish): mark lifecycle-lease-busy-grace SHIPPED

coderabbitai · 2026-08-03T03:31:34Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bdac2861-2644-41d3-91d1-869b35efcb35

📥 Commits

Reviewing files that changed from the base of the PR and between 9acbd7d and 6d252e6.

📒 Files selected for processing (24)

.claude-plugin/marketplace.json
.genie/wishes/lifecycle-lease-busy-grace/WISH.md
package.json
plugins/genie/.claude-plugin/plugin.json
plugins/genie/.codex-plugin/plugin.json
plugins/genie/package.json
plugins/hermes-genie/plugin.yaml
plugins/pi-genie/README.md
plugins/pi-genie/package.json
plugins/pi-genie/references/native-surface.md
plugins/pi-genie/scripts/install-local.sh
src/genie-commands/__tests__/update.test.ts
src/genie-commands/doctor.test.ts
src/genie-commands/doctor.ts
src/genie-commands/install.test.ts
src/genie-commands/install.ts
src/genie-commands/uninstall.test.ts
src/genie-commands/uninstall.ts
src/genie-commands/update.ts
src/lib/agent-sync.test.ts
src/lib/agent-sync.ts
src/lib/genie-home.test.ts
src/lib/genie-home.ts
src/lib/ordered-lifecycle-leases.ts

📝 Walkthrough

Walkthrough

The release centralizes lifecycle-busy messaging, expands Pi detection and synchronization, adds identity-safe Pi link cleanup during uninstall, updates related tests and documentation, and bumps package and plugin versions to 5.260803.6.

Changes

Genie release changes

Layer / File(s)	Summary
Lifecycle lease busy handling `src/lib/ordered-lifecycle-leases.ts`, `src/genie-commands/{install,update,uninstall}.ts`, `src/genie-commands/*test.ts`, `.genie/wishes/...`	The shared `lifecycleBusyMessage` formatter is used across lifecycle commands. Lease polling tests use a 500 ms bounded wait. The lifecycle wish records completed acceptance and QA results.
Pi detection and extension synchronization `src/lib/{agent-sync,genie-home}.`, `src/genie-commands/{doctor,doctor.test}.`, `plugins/pi-genie/...`	Pi detection accepts an existing agent directory or the Pi CLI. Blank environment overrides fall back to the configured Pi home. Synchronization creates the extensions directory and Genie link. Doctor tests cover missing and valid links.
Pi plugin-link uninstall support `src/genie-commands/{uninstall.ts,uninstall.test.ts}`	Uninstall tracks Pi extension paths, removes Genie-owned links, preserves foreign links and directories, and checks link identity before removal.
Release metadata synchronization `.claude-plugin/marketplace.json`, `package.json`, `plugins/**/{package.json,plugin.json,plugin.yaml}`	Package and plugin versions change from `5.260803.3` to `5.260803.6`.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

automagik-dev/genie#2542: Shares the agent-sync, doctor, install, uninstall, and related test areas.
automagik-dev/genie#2583: Shares Pi synchronization and uninstall areas.
automagik-dev/genie#2743: Directly precedes the Pi agent-sync and lifecycle-lease changes.

Suggested reviewers: automagik-genie

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 47.37% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies this pull request as an automated rolling promotion from dev to main.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

namastex888 and others added 8 commits August 2, 2026 23:34

Merge pull request #2747 from automagik-dev/fix/pr2743-review-round2

5c7a1d4

fix(review): resolve PR #2743 review threads

chore(version): bump to 5.260803.5 [auto-version]

01197df

Merge pull request #2748 from automagik-dev/fix/pr2743-review-round3

e5c9bc7

fix(pi): treat empty or whitespace pi env overrides as absent

chore(wish): mark lifecycle-lease-busy-grace SHIPPED

f55e574

Merged via #2745 into dev; QA complete including the end-to-end host update 5.260803.1 -> 5.260803.3 (borrowed-lease converge verified). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Merge pull request #2749 from automagik-dev/chore/wish-shipped-lifecy…

d4e5488

…cle-lease chore(wish): mark lifecycle-lease-busy-grace SHIPPED

chore(version): bump to 5.260803.6 [auto-version]

6d252e6

namastex888 merged commit 5807805 into main Aug 3, 2026
23 checks passed

Navigation Menu

chore: rolling promotion dev -> main - #2750

chore: rolling promotion dev -> main#2750
namastex888 merged 8 commits into
mainfrom
dev

namastex888 commented Aug 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

namastex888 commented Aug 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rolling Promotion PR

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

namastex888 commented Aug 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 3, 2026 •

edited

Loading