docs(wish): close pr-2545-ultra-release-gate (F01 closed, F02 recorde… - #2642
Conversation
…d unmet) - Status DONE; all nine success criteria checked against consolidated ledger evidence, with a note that per-group and QA criteria remain the historical execution record - F01 CLOSED: PR #2562 CI passed 15 checks / 0 failures on its exact head bd8c612 under CI's pinned Bun 1.3.11 (repo declares >=1.3.10) - F02 recorded **NOT MET**, not waived: #2562 carries one COMMENTED review and no APPROVED review, and the merging identity is the one the commits were authored under, so no independent approval exists - F05/F44 closed by observation: the metrics-updater has committed nothing since 2026-07-14 and the maintainer's routine list is empty, but the owning account was never identified, so deletion is inferred - standing conditions kept explicit: untrusted hook hashes, upstream- blocked startup probe, F16-F18/F31 still blocking stable release, no package rebuilt at the successor head, accepted lock/uninstall residuals pm-ledger-verify run 3 recorded: 21 findings, 18 must-fix (wrong exact SHA and a self-merge presented as independent approval) — all corrected before this commit.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fc29c7e2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | F03 | RH3, DX4 | PR/exposed | E | Migration caveat in create and promotion/edit notes; hardening criteria mapped | `release-publish.yml` idempotently appends marker `genie-agent-sync-migration-v1` on create and existing-release promotion; plugin docs and the B1–B7 map describe the operator-run second hop | | ||
| | F04 | RH4, SEC10, DX9 | Mixed | Current version-parity/build checks in B/D1/E; inherited verifier contract to stable-release wish | `release-payload-version.test.ts`, build staging verification, and source/extracted smoke own current parity; inherited publication/verifier redesign remains BLOCKING in the stable-release wish | | ||
| | F05 | RH5 | PR | E; **reopened operationally 2026-07-12** | Retired metrics state/README marker removed or superseding decision + schema test | Removed README marker and `.genie/agents/metrics-updater/**`; `release-docs.test.ts` **detects** resurrection but cannot prevent a direct-to-dev push. That happened: the external scheduled metrics-updater session pushed `d0ecc296` (2026-07-12) re-adding the state and README block after the PR merged, turning dev CI red against this gate. Re-retired in merge `af9fcad1`. **Open operational action: disable or re-scope the external metrics-updater routine — no repo commit can close this** | | ||
| | F05 | RH5 | PR | E; **reopened operationally 2026-07-12** | Retired metrics state/README marker removed or superseding decision + schema test | Removed README marker and `.genie/agents/metrics-updater/**`; `release-docs.test.ts` **detects** resurrection but cannot prevent a direct-to-dev push. That happened: the external scheduled metrics-updater session pushed `d0ecc296` (2026-07-12) re-adding the state and README block after the PR merged, turning dev CI red against this gate. Re-retired in merge `af9fcad1`, and again on `dev` in `6495bde4`. **CLOSED BY OBSERVATION 2026-07-24:** the scheduler committed daily at ~12:12 UTC from at least 2026-06-06 through 2026-07-14 (its final two firings, `ee50617f` and `4110962d`, were manually reverted in `fdffa95a` and `73ff992f`), then produced nothing for ten days. The claude.ai routine list queried from the maintainer's account is empty, but the owning account was never identified, so disablement is inferred from the silence rather than observed; nobody recorded performing the disable/re-scope action this row originally demanded. `dev` carries neither the state files nor the README marker, and `release-docs.test.ts` still fails closed on either | |
There was a problem hiding this comment.
Keep F05 open until routine disablement is verified
Because this row now closes F05/F44 solely from ten days of metrics silence while also saying the owning account was never identified and no disable/re-scope action was recorded, the previous direct-to-dev scheduler can still resume and re-break dev CI; release-docs.test.ts detects the bad state only after the push lands and cannot prevent it. Keep this operational gate open until the routine owner/disablement is verified instead of treating telemetry absence as closure.
Useful? React with 👍 / 👎.
…d unmet)
pm-ledger-verify run 3 recorded: 21 findings, 18 must-fix (wrong exact SHA and a self-merge presented as independent approval) — all corrected before this commit.