Skip to content

test(install): pin exit-2 fixture temp-parent mode to 0700 - #2627

Merged
namastex888 merged 1 commit into
devfrom
test/install-exit2-fixture-umask
Jul 22, 2026
Merged

namastex888 merged 1 commit into
devfrom
test/install-exit2-fixture-umask

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Summary

  • The install-exit2-propagation integration suite failed (exit 127 instead of the exit-2 contract) on any host with umask 0002: mkdirSync(work/tmp) inherited the umask and produced a group-writable (775) temp parent, which install.sh's validate_private_temp_root correctly rejects.
  • Pin the fixture dir to 0o700 so the test exercises the real exit-2 lifecycle regardless of host umask.

Verification

  • Before: both tests in the suite fail with status 127 on a umask-0002 host.
  • After: bun test tests/integration/install-exit2-propagation.test.ts → 2 pass / 0 fail on the same host.

Note (not fixed here)

When validate_private_temp_root dies at source time, die calls release_lifecycle_lock before it is defined, so the installer exits 127 instead of the contractual 1. Worth a small follow-up in install.sh.

🤖 Generated with Claude Code

On umask-0002 hosts mkdirSync creates the harness TMPDIR parent
group-writable (775), which install.sh's validate_private_temp_root
correctly rejects — the suite then failed with exit 127 instead of
exercising the exit-2 contract. Pin the fixture dir to 0700 so the
test is umask-independent.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 89d52872-3453-428a-853d-9caf1cc22d80

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/install-exit2-fixture-umask

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@namastex888
namastex888 merged commit 30c31d6 into dev Jul 22, 2026
12 checks passed
@automagik-genie
automagik-genie deleted the test/install-exit2-fixture-umask branch September 25, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant