docs(genie): live-dev-loop ledger — iterate-mode contract executed - #2620
Conversation
…ate-mode contract is live Design SHIP (digest 84cb10c4…) after one fix-first round; plan SHIP after two; G1/G3/G2 all execution-reviewed SHIP (one G3 fix loop: loopback bind); branch merged to khal-os/genie-desktop main 5a17077. ITERATE.md is the durable loop contract; genie memory carries the pointer. Wish IN_PROGRESS pending Felipe-live QA. Ledger pm-verified (2 must-fix INDEX-drift findings fixed; SC boxes checked per review evidence). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 725ba98c73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### IN | ||
|
|
||
| - **Browser channel (ultra-fast, primary view):** `pnpm dev:web` on the Linux box — Vite dev server bound to the network (`--host`, Tailscale/LAN reach, same opt-in posture as the ui-bridge HOST story) serving the agent's **working copy** directly. Latency = file save → HMR (sub-second); git is not in the hot path. The renderer runs against a **mocked `electronAPI`** (typed fixture module: sample projects/tasks/genie board state) — UI-only by design; every mocked surface is visibly watermarked in-app ("dev preview — mock data") so it can never masquerade as the real product. |
There was a problem hiding this comment.
Clarify dev:web must not bind the network by default
When a future implementer or operator follows this DESIGN.md scope, it directs pnpm dev:web to run Vite “bound to the network (--host)”, while the same design later says the server must be loopback by default with an explicit opt-in bind. That contradiction can lead to unintentionally exposing the dev preview on LAN/Tailscale, so the scope/approach should specify loopback default plus an explicit network flag consistently.
Useful? React with 👍 / 👎.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Docs-only ledger for the
live-dev-loopwish (Felipe's "i say change, you change" environment), adversarially pm-verified (2 must-fix INDEX-drift findings fixed before commit).5a17077: G1 full-interface mocked electronAPI + browser seam + watermark (drift guard proven by injection); G3 dev:live watcher + commit toasts + ITERATE.md (element-by-element faithfulness PASS; one fix loop for a loopback bind HIGH); G2 dev:web with mode-gated dev-only CSP (build-escape empirically closed).🤖 Generated with Claude Code