Skip to content

fix(agent-sync): honor home publish platform seam - #2591

Merged
namastex888 merged 1 commit into
devfrom
fix/routing-delivery-home-platform-seam
Jul 14, 2026
Merged

namastex888 merged 1 commit into
devfrom
fix/routing-delivery-home-platform-seam

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Context

Carries the two accepted CodeRabbit changes from #2590 that were pushed after GitHub had already merged that PR's earlier head. This branch is rebased onto dev 5.260714.7 and contains exactly one commit.

Changes

  • Use the shared explicit no-clobber platform selector for missing-GENIE_HOME publication as well as regular-file publication.
  • Extract the duplicated Darwin/Linux home publisher result/error handling into makeAgentSyncHomePublisher().
  • Add a deterministic forced-Linux test proving unavailable injected native setup selects the dedicated portable mkdir commit without process-global platform mutation or an explicit probe object.
  • Update the seam documentation to cover both native no-clobber callers.

Validation

  • Affected agent-sync fan-out/lock suite — 65 pass
  • Uninstall suite — 74 pass
  • Rebased focused regression — pass
  • bun run check:fast — pass
  • git diff --check origin/dev...HEAD — pass
  • Independent incremental review — SHIP, no CRITICAL/HIGH gaps
  • CodeRabbit confirmed both findings addressed; its Darwin caching suggestion was withdrawn after the one-shot workload/lifetime contract was explained.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@namastex888, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b4c1d570-ca22-4c1e-aa54-d6cbdf9506c7

📥 Commits

Reviewing files that changed from the base of the PR and between 1eb1955 and a563167.

📒 Files selected for processing (2)
  • src/lib/agent-sync.test.ts
  • src/lib/agent-sync.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/routing-delivery-home-platform-seam

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@namastex888

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the native agent-sync home publisher resolution to reuse platform selection logic and extract a helper function, 'makeAgentSyncHomePublisher', reducing code duplication between Darwin and Linux platforms. Additionally, a new test case has been added to verify that an explicit Linux platform with an unavailable native setup correctly falls back to the portable mkdir commit. There are no review comments, and the changes look clean and well-tested, so I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@namastex888
namastex888 merged commit 0fcfd5e into dev Jul 14, 2026
17 checks passed
@automagik-genie
automagik-genie deleted the fix/routing-delivery-home-platform-seam branch September 25, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant