Skip to content

fix(release): verify main promotions by content, not merge-commit message - #2551

Merged
namastex888 merged 2 commits into
devfrom
fix/promotion-trigger-content-match
Jul 11, 2026
Merged

namastex888 merged 2 commits into
devfrom
fix/promotion-trigger-content-match

Conversation

@namastex888

Copy link
Copy Markdown
Contributor

Goal-loop structural fix: version.yml gated the stable/homolog release on the head commit message starting with 'Merge pull request … /dev'. A rebase- or squash-merged dev→main PR produces no such commit, so the stable release silently never fired — observed on #2537 (2026-07-09) and #2542 (2026-07-10): main advanced, .well-known/latest.json stayed stale, and pre-guard clients downgraded (reproduced live on the reference machine).

Fix: job-level message conditions replaced by a 'Verify dev promotion' step on the no-bump path — promoted when the head commit IS a dev merge commit (legacy fast path) OR when the pushed content equals dev's tip excluding .well-known (what rebase/squash promotions produce; manifests land on main only, which is exactly where a rebased tree always differs). Non-promotions skip the dispatch with a ::notice. If dev advanced past the PR head, the content check misses and the next promotion catches up — same posture as the existing atomic tag-push race.

Effect: the pending #2545 promotion publishes stable regardless of which merge button gets clicked.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: dcbe9ed1-7fe2-49ce-9165-953aa3963086

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/promotion-trigger-content-match

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7505a83795

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

startsWith(github.event.workflow_run.head_commit.message, 'Merge pull request') &&
contains(github.event.workflow_run.head_commit.message, '/dev'))
||
(github.event.workflow_run.head_branch == 'main') ||

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Scope the auto-version skip away from rebase promotions

This new main promotion path is still nested under the job-level !contains(..., '[auto-version]') guard above. The dev bump step creates the dev tip as chore(version): ... [auto-version], so when the dev→main PR is rebase-merged and that rebased bump commit becomes the push head, workflow_run.head_commit.message contains [auto-version] and the entire job is skipped before Verify dev promotion can do the content check. In that merge mode, the stable dispatch still never fires; scope the auto-version skip to the dev bump path or otherwise let main promotions reach the promotion gate.

Useful? React with 👍 / 👎.

@namastex888
namastex888 force-pushed the fix/promotion-trigger-content-match branch from 7505a83 to 4915087 Compare July 11, 2026 01:51
@namastex888
namastex888 merged commit 26715d4 into dev Jul 11, 2026
17 of 19 checks passed
@automagik-genie
automagik-genie deleted the fix/promotion-trigger-content-match branch September 25, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant