Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add course number #1637

Merged
merged 17 commits into from
Nov 23, 2022
Merged

Add course number #1637

merged 17 commits into from
Nov 23, 2022

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented Nov 6, 2022

Description

  • Add field to CUD table to store course number
  • Display course number where relevant (gradebook / gradesheet / manage students / course profile)
  • Update add user to course form to support course number
  • Update roster import to support course numbers
  • Add "by course" statistics to statistics page

Misc

  • Prettify course average tweak section of add user to course
  • Left-align emails in gradebook, remove redundant CSV (the classes don't exist, they're all .tip)
  • Increase default width of columns in gradebook
  • Remove dead reference to assessments_show in show.html.erb
  • Lint Form Builder

Motivation and Context

Record course numbers for students, so that students from different courses but in the same autolab course can be distinguished.

How Has This Been Tested?

  • Successfully import course number via autolab format / CMU roster format (for a new student)
  • Successfully import course number via autolab format / CMU roster format (for an existing student). Essentially, upload the same roster for the previous part, but with some data changed (such as course number). After saving the roster, the changes should be reflected.
  • Ensure that import success / error tables show course number (when it exists)
  • Ensure that gradebook / manage student tables show course number (when it exists)
  • Ensure that add user to course form is able to correctly create user with course number
  • Ensure that you can edit the course number of an existing user

Import Autolab Format / CMU Roster Format
Autolab Format: M22,[email protected],Ho,Damian,SCS,CS,2025,L,15122,1,A
CMU Roster Format: Semester,Course,Section,Lecture,Mini,Last Name,Preferred/First Name,MI,Andrew ID,Email,College,Department,Major,Class,Graduation Semester,Units,Grade Option,QPA Scale,Mid-Semester Grade,Primary Advisor,Final Grade,Default Grade,Time Zone Code,Time Zone Description,Added By,Added On,Confirmed,Waitlist Position,Units Carried/Max Units,Waitlisted By,Waitlisted On,Dropped By,Dropped On,Roster As Of Date

M22,15122,A,1,N,Ho,Damian,,xho,[email protected],SCS,CS,CS,3,F25,0,L,4+,,Test Advisor,,,EST,Eastern Standard Time (GMT-5:00),fake_andrewid,11 Jul 2022,Y,,,,,,,11 Jul 2022 12:00 AM
Screenshot 2022-11-10 at 21 41 06

Import error table
Autolab Format: M22,[email protected],,,SCS,CS,2025,L,15122,1,A
Screenshot 2022-11-10 at 21 41 43

Course number appears on gradebook / gradesheet / manage students / course profile
(Note: gradebook's email cells are now left-aligned as was intended, cells are also wider)
Screenshot 2022-11-10 at 21 41 55
Screenshot 2022-11-10 at 21 42 04
Screenshot 2022-11-10 at 21 42 16
Screenshot 2022-11-10 at 21 42 26

Add user to course form
Screenshot 2022-11-06 at 15 16 04

Statistics by course
Screenshot 2022-11-10 at 21 42 48

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

@damianhxy damianhxy marked this pull request as ready for review November 7, 2022 17:07
@damianhxy damianhxy changed the title [WIP] Add course number Add course number Nov 7, 2022
@michellexliu michellexliu requested review from najclark and removed request for victorhuangwq November 13, 2022 20:22
Copy link
Contributor

@najclark najclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes look good, however for users that are added via 'Import roster/users' the course number shows up in the import course roster table
Screen Shot 2022-11-22 at 9 00 42 PM
(the row is black, because I re-imported the csv for the screenshot)
but it doesn't seem like the course number shows up with the student
Screen Shot 2022-11-22 at 9 04 03 PM
Screen Shot 2022-11-22 at 9 04 29 PM

Users added via the 'Add user to course' button do seem to have the course number.

Copy link
Contributor

@najclark najclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, confirmed that users uploaded via 'import roster' had course number, and when uploading an updated csv, the change in course number was reflected.

@damianhxy damianhxy merged commit 863f989 into master Nov 23, 2022
@damianhxy damianhxy deleted the add-course-number branch November 23, 2022 21:56
@reviewpad reviewpad bot added the large Pull request is large label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants