-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add course number #1637
Add course number #1637
Conversation
- Remove unused CSS - Fix left align for email cells - Add columns for course and lecture - Increase width for readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes look good, however for users that are added via 'Import roster/users' the course number shows up in the import course roster table
(the row is black, because I re-imported the csv for the screenshot)
but it doesn't seem like the course number shows up with the student
Users added via the 'Add user to course' button do seem to have the course number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, confirmed that users uploaded via 'import roster' had course number, and when uploading an updated csv, the change in course number was reflected.
Description
add user to course
form to support course numberMisc
course average tweak
section ofadd user to course
.tip
)assessments_show
inshow.html.erb
Motivation and Context
Record course numbers for students, so that students from different courses but in the same autolab course can be distinguished.
How Has This Been Tested?
add user to course
form is able to correctly create user with course numberImport Autolab Format / CMU Roster Format
Autolab Format:
M22,[email protected],Ho,Damian,SCS,CS,2025,L,15122,1,A
CMU Roster Format:
Semester,Course,Section,Lecture,Mini,Last Name,Preferred/First Name,MI,Andrew ID,Email,College,Department,Major,Class,Graduation Semester,Units,Grade Option,QPA Scale,Mid-Semester Grade,Primary Advisor,Final Grade,Default Grade,Time Zone Code,Time Zone Description,Added By,Added On,Confirmed,Waitlist Position,Units Carried/Max Units,Waitlisted By,Waitlisted On,Dropped By,Dropped On,Roster As Of Date
M22,15122,A,1,N,Ho,Damian,,xho,[email protected],SCS,CS,CS,3,F25,0,L,4+,,Test Advisor,,,EST,Eastern Standard Time (GMT-5:00),fake_andrewid,11 Jul 2022,Y,,,,,,,11 Jul 2022 12:00 AM
Import error table
Autolab Format:
M22,[email protected],,,SCS,CS,2025,L,15122,1,A
Course number appears on gradebook / gradesheet / manage students / course profile
(Note: gradebook's email cells are now left-aligned as was intended, cells are also wider)
Add user to course form
Statistics by course
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting