Updated parameter handling for Ollama #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ollama test failed. |
|
@marklysze can you check the ollama test failure. otherwise looks good to me. |
|
Ollama test failed. But LGTM |
olaoluwasalami
approved these changes
Oct 2, 2024
odoochain
pushed a commit
to odoochain/autogen
that referenced
this pull request
Nov 10, 2024
odoochain
pushed a commit
to odoochain/autogen
that referenced
this pull request
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ollama's API expects a number of LLM parameters to now be in the options attribute. Have updated the library to move a number of parameters into the options dictionary attribute.
Parameters that should be in the options dictionary noted here.
Related issue number
None
Checks