Mark RegisterGeneratedFactory obsolete - #1366
Merged
Merged
Conversation
This includes: - GeneratedFactoryActivatorData being obsolete - Suppressing the obsolete warnings around unit tests temporarily until it's removed.
Codecov ReportBase: 78.22% // Head: 78.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1366 +/- ##
===========================================
- Coverage 78.22% 78.15% -0.07%
===========================================
Files 197 197
Lines 5653 5636 -17
Branches 1147 1149 +2
===========================================
- Hits 4422 4405 -17
Misses 716 716
Partials 515 515
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alistairjevans
requested changes
Feb 5, 2023
alistairjevans
left a comment
alistairjevans
left a comment
Member
There was a problem hiding this comment.
Looks great, only thing I noticed was a possible instance of a missing static on two of the new local methods.
This was referenced Oct 2, 2025
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1297.
This marks
RegisterGeneratedFactoryextensions andGeneratedFactoryActivatorDatawith an[Obsolete]attribute indicating folks should upgrade to useFunc<T>or delegate factories. Tests for the feature remain, but the obsolete warnings are suppressed around the tests so we don't see them during the build.While I was here I picked up a couple of optimizations based on Roslyn analyzers: