Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json1 support #2

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Add json1 support #2

merged 1 commit into from
Feb 16, 2022

Conversation

DanielRBaird
Copy link

@DanielRBaird DanielRBaird commented Feb 16, 2022 •
edited
Loading

An issue exists here on sqldelight main repo for adding support for json1: sqldelight#1379

We require json1 for a handful of things in PlanGrid Build, so until this is supported in the main repo we need to continue to add support ourselves.

bradmcmanus
bradmcmanus approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@bradmcmanus bradmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken record: more info is great for posterity. link to sqldelight issue talking about json extensions. description why we use json extensions, etc...

@DanielRBaird DanielRBaird merged commit f15cf21 into plangrid-publish Feb 16, 2022
@DanielRBaird DanielRBaird deleted the daniel/addJson1 branch February 16, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradmcmanus bradmcmanus bradmcmanus approved these changes

Assignees

@njw438 njw438

@bradmcmanus bradmcmanus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielRBaird @bradmcmanus @njw438