-
Notifications
You must be signed in to change notification settings - Fork 4
Update apache-arrow for 2.0.0 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there any way to disable avx512 on unsupported compilers, so that we can build on osx 10.11? I already tried to cheat by using the 10.13 libarrow binaries to build the R package on 10.11, however that results in a linking error |
|
Given https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L107-L122, it looks like we can set Presumably though if the compiler doesn't support AVX512 then we shouldn't be using it, so that suggests that the check for support (here I think? https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L55) isn't doing the right thing for this compiler. |
|
Yeah let's try that, see what the CI says. |
|
Same error... looks like I think you need to condition that on ARROW_RUNTIME_SIMD_LEVEL as done here: https://github.com/apache/arrow/blob/44f3de2c2854a473d4ce184e02c4db83dffb805d/cpp/cmake_modules/SetupCxxFlags.cmake#L73 |
|
You mean something like this? apache/arrow@699d702 |
|
That appears to have allowed |
|
Perfect, thanks! |
cf. r-windows/rtools-packages#160