Skip to content

Conversation

@nealrichardson
Copy link
Contributor

@nealrichardson nealrichardson commented Oct 15, 2020

@jeroen
Copy link
Contributor

jeroen commented Oct 15, 2020

Is there any way to disable avx512 on unsupported compilers, so that we can build on osx 10.11?

I already tried to cheat by using the 10.13 libarrow binaries to build the R package on 10.11, however that results in a linking error Symbol not found: _os_unfair_lock_lock for something in libarrow_bundled_dependencies.a (probably jemalloc).

@nealrichardson
Copy link
Contributor Author

Given https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L107-L122, it looks like we can set ARROW_RUNTIME_SIMD_LEVEL to something less--what would be appropriate, AVX2?

Presumably though if the compiler doesn't support AVX512 then we shouldn't be using it, so that suggests that the check for support (here I think? https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L55) isn't doing the right thing for this compiler.

@jeroen
Copy link
Contributor

jeroen commented Oct 15, 2020

Yeah let's try that, see what the CI says.

@jeroen
Copy link
Contributor

jeroen commented Oct 15, 2020

Same error... looks like util/bpacking_avx512.cc is included unconditionally.

I think you need to condition that on ARROW_RUNTIME_SIMD_LEVEL as done here: https://github.com/apache/arrow/blob/44f3de2c2854a473d4ce184e02c4db83dffb805d/cpp/cmake_modules/SetupCxxFlags.cmake#L73

@nealrichardson
Copy link
Contributor Author

You mean something like this? apache/arrow@699d702

@nealrichardson
Copy link
Contributor Author

That appears to have allowed brew install to succeed

@jeroen
Copy link
Contributor

jeroen commented Oct 15, 2020

Perfect, thanks!

@nealrichardson nealrichardson marked this pull request as ready for review October 19, 2020 20:51
@jeroen jeroen merged commit 575acc9 into autobrew:master Oct 19, 2020
@nealrichardson nealrichardson deleted the patch-5 branch October 19, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants