Skip to content

Conversation

@jeroen
Copy link
Contributor

@jeroen jeroen commented Aug 1, 2022

No description provided.

@jeroen
Copy link
Contributor Author

jeroen commented Aug 1, 2022

Looking good.

Co-authored-by: Neal Richardson <[email protected]>
Copy link

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We add -DARROW_VERBOSE_THIRDPARTY_BUILD=ON for better CI troubleshooting but that shouldn't be added here. Other than that I don't see anything missing. (except the alphabetical order of the cmake args ;) ) 👍

@jeroen jeroen merged commit 9f59b29 into high-sierra Aug 3, 2022
@jeroen jeroen deleted the arrow9 branch August 3, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants