Avoid using shell option for autify-with-proxy #394
Merged
+4,049
−4,807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsmfm
force-pushed
the
mtsmfm/dont-use-shell
branch
from
aa66854
to
b398aad
Compare
mtsmfm
commented
Apr 6, 2023
| const autify = AUTIFY_CLI_PATH ?? "autify"; | ||
| let autify = AUTIFY_CLI_PATH ?? "autify"; | ||
| if (process.platform === "win32") { | ||
| autify += ".cmd"; |
There was a problem hiding this comment.
Because child_process.spawn ignores PATHEXT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly the change is 1a5b628
Other commits are just for updating recordings.
Because of this
shelloption, quotes will be removed whenautify-with-proxypasses arguments toautifyCLI but both our GitHub and CircleCI integration won't have any quotes.autifyhq/actions-web-test-run#33
To remove quotes from recordings files and keep the behavior as the same as integrations, I'd like to avoid
shelloption.