Add datastore proxy for separating context #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the order that datastore is wrapped so that the observable proxy also measures caching.
github-actions
bot
added
area/CLI
jzelinskie
force-pushed
the
fix-observable
branch
8 times, most recently
from
ca9d485 to
dfd37e4
Compare
Pulls the logic for seperating the read-only methods context for datastores that benefit from a lack of canceling connections.
jzelinskie
force-pushed
the
fix-observable
branch
from
dfd37e4 to
643d03c
Compare
vroldanbet
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the footguns for datastores that need to separate context before performing read-only actions.