Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes memory leak via HTTP Gateway #2075

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fixes memory leak via HTTP Gateway #2075

merged 1 commit into from
Sep 24, 2024

Conversation

vroldanbet
Copy link
Contributor

bumping otelhttp component fixed it

I noticed via the logs that this issue was getting triggered. After reproducing the leak, and bumping to version 0.55.0, the problem disappeared.

This is what we observed in a memory profile
image (2)

@vroldanbet vroldanbet requested a review from a team as a code owner September 24, 2024 11:09
@github-actions github-actions bot added the area/dependencies Affects dependencies label Sep 24, 2024
@vroldanbet vroldanbet force-pushed the http-otel-leak branch 2 times, most recently from dfee601 to 34654cd Compare September 24, 2024 11:28
bumping otelhttp component fixed it
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@vroldanbet vroldanbet added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 7f6f270 Sep 24, 2024
22 checks passed
@vroldanbet vroldanbet deleted the http-otel-leak branch September 24, 2024 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependencies Affects dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants