Ensure the validationfile loader passes the full caveats to the typesystem #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
tstirrat15
approved these changes
Aug 29, 2024
| @@ -121,6 +124,7 @@ func PopulateFromFilesContents(ctx context.Context, ds datastore.Datastore, file | |||
| ts, err := typesystem.NewNamespaceTypeSystem(objectDef, | |||
| typesystem.ResolverForDatastoreReader(rwt).WithPredefinedElements(typesystem.PredefinedElements{ | |||
| Namespaces: objectDefs, | |||
| Caveats: caveatDefs, | |||
There was a problem hiding this comment.
I take it this was the root of it?
There was a problem hiding this comment.
Likely, yes, although I wasn't able to fully reproduce
Comment on lines
+9
to
+11
| caveat some_caveat(somecondition int) { | ||
| somecondition == 42 | ||
| } |
There was a problem hiding this comment.
Was the issue that the caveat was defined below the resource?
There was a problem hiding this comment.
No, but I figured I'd add a test just the same
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2001