Add a default connect timeout for watch in CRDB driver #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
vroldanbet
reviewed
Aug 27, 2024
internal/datastore/crdb/watch.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| const ( | |||
| queryChangefeed = "EXPERIMENTAL CHANGEFEED FOR %s WITH updated, cursor = '%s', resolved = '%s', min_checkpoint_frequency = '0';" | |||
| queryChangefeedPreV22 = "EXPERIMENTAL CHANGEFEED FOR %s WITH updated, cursor = '%s', resolved = '%s';" | |||
| watchConnectTimeout = 1 * time.Second | |||
There was a problem hiding this comment.
I'd suggest making this more conservative, and tunable. The code moves from no timeout at all to 1 second, and that could backfire in situations where a CRDB cluster is at capacity
There was a problem hiding this comment.
That's actually kind of the point - it would fail fast and then they'd retry. It only applies on the initial connect
This ensures that if the new connection used for watch hangs, it will timeout
josephschorr
force-pushed
the
crdb-watch-timeout
branch
from
0802759
to
bc7d7cf
Compare
vroldanbet
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if the new connection used for watch hangs, it will timeout