Cleanup handling of internal errors in Check dispatch #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
approved these changes
Aug 19, 2024
| @@ -404,22 +398,12 @@ func (cc *ConcurrentChecker) checkDirect(ctx context.Context, crc currentRequest | |||
| return checkResultError(NewCheckFailureErr(it.Err()), emptyMetadata) | |||
| } | |||
|
|
|||
| spiceerrors.DebugAssert(func() bool { | |||
| return tuple.OnrEqualOrWildcard(tpl.Subject, crc.parentReq.Subject) | |||
There was a problem hiding this comment.
Curious - is this somehow capturing the local context for logging purposes? Or do we have a good enough idea of what's going on here that we don't need (for example) the tuple string?
There was a problem hiding this comment.
It would panic when tests are being run, so we'd have a full stack trace
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.