add setting to configure when to raise the user unload event and remove user always before requesting sign-out - #1391
add setting to configure when to raise the user unload event and remove user always before requesting sign-out#1391pamapa wants to merge 1 commit into
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
+ Coverage 79.78% 79.83% +0.05%
==========================================
Files 45 45
Lines 1731 1741 +10
Branches 344 348 +4
==========================================
+ Hits 1381 1390 +9
- Misses 312 313 +1
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ys before requesting sign-out
|
@PSanetra Can you review and test?
Any better name for |
|
|
||
| await this.removeUser(); | ||
| logger.debug("user removed"); | ||
| if (!this.settings.raiserUserUnloadEventBeforeSignoutRequest) { |
There was a problem hiding this comment.
maybe we should just call await this._removeUser(true) here, it should not hurt and is simpler (less code)
There was a problem hiding this comment.
I think this should be ok as a signed in user would be unexpected in any case, right?
|
I think The user/ developer is expected to set |
|
I think this solution is too complicated, i do not like an option for this at all. The previous behavior (<v3.0) was dead simple |
Closes/fixes #1379
Checklist