Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove VaultUnlockVerification from popup #309

Merged
merged 1 commit into from
Feb 22, 2023
Merged

remove VaultUnlockVerification from popup #309

merged 1 commit into from
Feb 22, 2023

Conversation

capaj
Copy link
Collaborator

@capaj capaj commented Feb 22, 2023

it was causing vault to try to render in popup

@capaj
remove VaultUnlockVerification from popup
7187e38 
it was causing vault to try to render in popup
@capaj capaj added the bug Something isn't working label Feb 22, 2023
@capaj capaj requested a review from sleaper February 22, 2023 14:18
sleaper
sleaper approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@sleaper sleaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sleaper sleaper merged commit 462edf6 into main Feb 22, 2023
@sleaper sleaper deleted the fix-vault-render-issue-in-popup branch February 22, 2023 15:05
capaj added a commit that referenced this pull request May 11, 2023
@capaj
remove VaultUnlockVerification from popup (#309)
e9569be 
Former-commit-id: 462edf6
capaj added a commit that referenced this pull request May 11, 2023
@capaj
remove VaultUnlockVerification from popup (#309)
74442ce 
Former-commit-id: b7924847ccd65ecea08503b950aa260d607f5245 [formerly 462edf6]
Former-commit-id: e9569be
capaj added a commit that referenced this pull request May 11, 2023
@capaj
remove VaultUnlockVerification from popup (#309)
488a9ee 
Former-commit-id: b7924847ccd65ecea08503b950aa260d607f5245 [formerly b7924847ccd65ecea08503b950aa260d607f5245 [formerly 462edf6]]
Former-commit-id: 2ab008c83f753f57c7b437cf8561931979036ee1 [formerly e9569be]
Former-commit-id: 74442ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleaper sleaper sleaper approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capaj @sleaper