make popup appear faster #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capaj
changed the title
capaj
added a commit
that referenced
this pull request
May 11, 2023
* unify getDomainNameAndTldFromUrl in shared * make popup init faster Former-commit-id: 6f5f920
capaj
added a commit
that referenced
this pull request
May 11, 2023
capaj
added a commit
that referenced
this pull request
May 11, 2023
* unify getDomainNameAndTldFromUrl in shared * make popup init faster Former-commit-id: 2808cfdccfd51a3f1c170ddaa805092c809b1555 [formerly 2808cfdccfd51a3f1c170ddaa805092c809b1555 [formerly 6f5f920]] Former-commit-id: 6451315c5d227d8f309f7f223755e8b3fdf2965e [formerly 6c5619d] Former-commit-id: 833e88f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unify getDomainNameAndTldFromUrl in shared
this fixes a scenario when we would be autocompleting, but popup was showing 0 logins because popup was filtering by whole hostname, not just domain+TLD
make popup appear faster