Improved OIDC compliance #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
reviewed
Nov 5, 2019
There was a problem hiding this comment.
@davidpatrick - I might be missing something here ... added a number of comments here and I'll pause before continuing the review.
Also, it looks like you're testing the different parts of the verification but not the whole process (so we can make sure all this logic is for sure getting called). I was looking for a test to show me how jwt.verify() was getting called. The existing tests should help show if that's even possible and how.
davidpatrick
force-pushed
the
idtoken_validation
branch
from
8946dfc
to
160f081
Compare
joshcanhelp
suggested changes
Nov 14, 2019
davidpatrick
force-pushed
the
idtoken_validation
branch
3 times, most recently
from
aa3e358
to
a96de9a
Compare
joshcanhelp
suggested changes
Nov 15, 2019
davidpatrick
force-pushed
the
idtoken_validation
branch
from
1aad1db
to
05e1449
Compare
davidpatrick
force-pushed
the
idtoken_validation
branch
2 times, most recently
from
da36735
to
7667fe9
Compare
davidpatrick
force-pushed
the
idtoken_validation
branch
from
7667fe9
to
7f50103
Compare
joshcanhelp
previously approved these changes
Nov 18, 2019
|
@gkwang - Ready for your review! |
gkwang
suggested changes
Nov 18, 2019
|
Can we also make sure we bump passport-oauth2's version to 1.5.0 before we release a new version? It contains all the PKCE changes. jaredhanson/passport-oauth2@v1.4.0...jaredhanson:v1.5.0 |
davidpatrick
force-pushed
the
idtoken_validation
branch
from
ad50d68
to
09f1814
Compare
gkwang
previously approved these changes
Nov 18, 2019
gkwang
approved these changes
Nov 18, 2019
joshcanhelp
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This update improves the SDK support for OpenID Connect. In particular, it modifies the sign in verification phase by substituting backchannel based checks with id_token validation.
References
Internal Docs
Testing
This change adds test coverage
This change has been tested on the latest stable version of Node.js
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors