Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strategy constructor to not mutate options argument #92

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fix strategy constructor to not mutate options argument #92

merged 1 commit into from
Aug 7, 2019

Conversation

naptowncode
Copy link
Contributor

Description

Fix Strategy constructor to copy the options argument object instead of mutating it. Includes a new unit test to confirm this behavior.

References

Fixes issue #91.

Testing

  • This change adds test coverage for fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All existing and new tests complete without errors

@naptowncode naptowncode requested a review from a team August 7, 2019 16:32
lbalmaceda
lbalmaceda approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@lbalmaceda lbalmaceda merged commit 99c6673 into auth0:master Aug 7, 2019
@lbalmaceda lbalmaceda added this to the v1-Next milestone Aug 7, 2019
@joshcanhelp joshcanhelp modified the milestones: v1-Next, v1.2.1 Aug 12, 2019
@snyk-bot snyk-bot mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@naptowncode @lbalmaceda @joshcanhelp