Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2811] Replace request with axios #144

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Sep 24, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Request has been deprecated for a while now, see request/request#3142.
This PR replaces request with axios.

Request was only used in the _getAccessToken method on the Auth0Strategy which is marked as TODO: Obsolete.
I agree with the fact that this method should be marked obsolete and, ideally, get removed in a future version. I properly marked the method as obsolete.

References

#137

Testing

Calling _getAccessToken still gives you the corresponding tokens in the callback.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@frederikprijck frederikprijck requested a review from a team as a code owner September 24, 2021 12:06
@frederikprijck frederikprijck changed the title Replace request with got Replace request with axios Sep 24, 2021
@frederikprijck frederikprijck changed the title Replace request with axios [SDK-2811] Replace request with axios Sep 24, 2021
@frederikprijck frederikprijck merged commit 1aaf257 into master Sep 28, 2021
@frederikprijck frederikprijck deleted the frederik/sdk-2811 branch September 28, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants