[SDK-2811] Replace request with axios #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Request has been deprecated for a while now, see request/request#3142.
This PR replaces
request
withaxios
.Request was only used in the
_getAccessToken
method on theAuth0Strategy
which is marked asTODO: Obsolete
.I agree with the fact that this method should be marked obsolete and, ideally, get removed in a future version. I properly marked the method as obsolete.
References
#137
Testing
Calling
_getAccessToken
still gives you the corresponding tokens in the callback.Checklist
master