Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2.1 -> 1.3.1 upgrade causes "Cannot read property 'scope' of undefined" #107

Closed
pihvi opened this issue Dec 21, 2019 · 1 comment · Fixed by #108
Closed

1.2.1 -> 1.3.1 upgrade causes "Cannot read property 'scope' of undefined" #107

pihvi opened this issue Dec 21, 2019 · 1 comment · Fixed by #108
Milestone
v1.3.2

Comments

@pihvi
Copy link
Contributor

pihvi commented Dec 21, 2019

My Express app started to fail logins after upgrading from 1.2.1 to 1.3.1

Here's the error:

Cannot read property 'scope' of undefined
    at handleIdTokenValidation (.../node_modules/passport-auth0/lib/verifyWrapper.js:38:18)
@pihvi
Copy link
Contributor Author

pihvi commented Dec 21, 2019

passport-auth0/lib/verifyWrapper.js

Line 38 in 032d129

if (authParams.scope && authParams.scope.includes('openid')) {

There seems to be an access to possibly undefined parameter?

pihvi added a commit to pihvi/passport-auth0 that referenced this issue Dec 21, 2019
@pihvi
Guard against undefined parameter access
d18be0b 
Closes auth0#107
@pihvi pihvi mentioned this issue Dec 21, 2019
Merged
@joshcanhelp joshcanhelp mentioned this issue Dec 29, 2019
Closed
joshcanhelp pushed a commit that referenced this issue Dec 31, 2019
@pihvi @joshcanhelp
Guard against undefined parameter access
7879fad 
Closes #107
@joshcanhelp joshcanhelp added this to the v1.3.2 milestone Dec 31, 2019
@snyk-bot snyk-bot mentioned this issue May 6, 2020
Merged
@davidpatrick davidpatrick mentioned this issue Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging a pull request may close this issue.

Guard against undefined parameter access pihvi/passport-auth0
2 participants
@pihvi @joshcanhelp