Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated dependency querystring #138

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove deprecated dependency querystring #138

wants to merge 5 commits into from

Conversation

aelliott1485
Copy link

Description

Per issue 137 the dependency querystring is deprecated. The changes here remove that dependency.

References

issue 137

Testing

I created a Dockerfile with the node 12

# specify the node base image with your desired version node:<version>
FROM node:12

and changed it for node 16:

# specify the node base image with your desired version node:<version>
FROM node:12

Then I add a mount (with the -v parameter) to /code. I could then run cd code && npm run cover

Checklist

  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@aelliott-atlas
Copy link

@jakelacey2012, @machadolucasvp or @julienwoll would one of you be able to take a peek at this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelliott1485 @aelliott-atlas