Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node version 20 #108

Merged
merged 1 commit into from
May 18, 2023
Merged

Add support for Node version 20 #108

merged 1 commit into from
May 18, 2023

Conversation

EdenGottlieb
Copy link

@EdenGottlieb EdenGottlieb commented May 18, 2023 •
edited
Loading

Description

Added support for Node version 20.
Also fix a small markdown formatting issue in the README section describing supported versions.

Testing

No additional testing required.
All tests pass.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Add support for Node version 20
2426389 
Added support for Node version 20.
All tests pass
@EdenGottlieb EdenGottlieb requested a review from a team as a code owner May 18, 2023 10:29
adamjmcgrath
adamjmcgrath approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EdenGottlieb!

@adamjmcgrath adamjmcgrath merged commit 6ddd164 into auth0:main May 18, 2023
@EdenGottlieb
Copy link
Author

@adamjmcgrath
Always happy to help :)
Is there any chance a new version with this change will be released soon?
I'm have node 20 and this package keeps failing npm installs since node 20 is not listed as supported (nvm use fixes this but it's slow and annoying)

@adamjmcgrath adamjmcgrath mentioned this pull request May 24, 2023
Merged
@adamjmcgrath
Copy link
Contributor

👋 @EdenGottlieb - this should get released shortly #109

This was referenced May 18, 2024
Open
Open
Open
Open
Open
Open
This was referenced May 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jun 2, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@regreaves regreaves mentioned this pull request Jun 10, 2024
Open
This was referenced Aug 18, 2024
Open
Open
Open
Open
Open
Open
This was referenced Aug 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 2, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 9, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdenGottlieb @adamjmcgrath