Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript declarations for v2 #229

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Fix typescript declarations for v2 #229

merged 3 commits into from
Mar 12, 2021

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Mar 12, 2021

The v2 removed the callback based methods from the client and removed the Async suffix from the promise based methods.
The typescript prototype was not aligned with this change though, which makes it hard for typescript developers to "catch" such change by upgrading the package.
It also makes it hard for first time users of this package to discover the methods and what's available.

This PR fixes the misalignment created by the changes in v2

Closes #228 and #230

Callback is supported on getSigningKey
@davidpatrick davidpatrick changed the title - fixes a bug where typescript declarations would not be matching v2 prototype Fix typescript declarations for v2 Mar 12, 2021
@davidpatrick davidpatrick merged commit 949e34a into auth0:master Mar 12, 2021
@davidpatrick
Copy link
Contributor

Thanks @baywet for the quick catch here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typescript definition for 2.0.0 release
3 participants