Add missing async methods to Typescript type definitions #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods were added by auth0#161, but the PR did not include an update to the matching Typescript type definitions. Without this update, these new methods are unusable in Typescript projects.
jimmyjames
approved these changes
Aug 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New "async" methods that return promises were added by #161, but the PR did not include an update to the matching Typescript type definitions. Without this update, these new methods are unusable in Typescript projects.
References
See PR #161 that was merged and included in today's release (v1.9.0).
Testing
There is a "ts type definitions" test file:
https://github.com/auth0/node-jwks-rsa/blob/master/tests/ts-definitions.tests.ts
But I'm not really sure what it's testing or how it's supposed to work.