Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send the explicit commit SHA to Codecov #128

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Send the explicit commit SHA to Codecov #128

merged 1 commit into from
Feb 18, 2020

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Feb 18, 2020 •
edited
Loading

This PR makes the coverage reporting command work when a GH rebase has occurred

See the latest build failed with:

HTTP 400
Commit sha does not match Circle build.

@lbalmaceda lbalmaceda requested a review from a team February 18, 2020 16:46
@davidpatrick davidpatrick merged commit 5fc0f15 into master Feb 18, 2020
@lbalmaceda lbalmaceda deleted the lbalmaceda-patch-1 branch February 18, 2020 16:51
@davidpatrick davidpatrick added this to the 1.7.0 milestone Feb 18, 2020
@davidpatrick davidpatrick mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbalmaceda @davidpatrick