-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias for obtaining the public key #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
suggested changes
Jan 18, 2020
damieng
reviewed
Jan 20, 2020
Added readme changes. Will add a small paragraph to the changelog on the next release instructing to use the new method. |
lbalmaceda
force-pushed
the
fix-type-bc
branch
from
January 20, 2020 17:49
0691186
to
5dbf5c6
Compare
damieng
reviewed
Jan 20, 2020
damieng
reviewed
Jan 20, 2020
damieng
approved these changes
Jan 21, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to provide backwards compatibility for obtaining the PEM representation of the public key (RSA or not).
When this is merged, users of the library can quickly access the public key instance of the
jwk
object by callinggetPublicKey()
.References
Nothing linked here yet
Testing
Added unit tests that assert that the
pem
property has the same value as thepublicKey
andrsaPublicKey
properties.Checklist
master