Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tilde-indexOf with includes #647

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Replace tilde-indexOf with includes #647

merged 2 commits into from
Feb 10, 2020

Conversation

dviryamin
Copy link
Contributor

Description

Replaces the mystery way of checking if string contains other string using ~str.indexOf with str.includes.

@ziluvatar
Copy link
Contributor

Could you remove the package-lock.json file?

@dviryamin
Copy link
Contributor Author

Could you remove the package-lock.json file?

Done.

@ziluvatar ziluvatar merged commit 88cb9df into auth0:master Feb 10, 2020
@ziluvatar
Copy link
Contributor

Thanks @dviryamin !! 👏

@dviryamin dviryamin deleted the remove-tilde-indexof branch February 14, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacineMTB yacineMTB yacineMTB approved these changes

@ziluvatar ziluvatar ziluvatar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dviryamin @ziluvatar @yacineMTB