Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At error cause to AT error when it's from a failed grant #878

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

adamjmcgrath
Copy link
Contributor

📋 Changes

When the access token error comes from a failed grant request we should create an AccessTokenError with an IdentityProvider error as a cause

📎 References

fixes #872

@adamjmcgrath adamjmcgrath added the review:small Small review label Oct 21, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner October 21, 2022 16:11
@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nextjs-auth0 ⬜️ Ignored (Inspect) Oct 21, 2022 at 5:09PM (UTC)

@@ -1,7 +1,8 @@
import { NextMiddleware, NextRequest, NextResponse } from 'next/server';
import { default as CookieStore } from './auth0-session/cookie-store';
import MiddlewareCookies from './utils/middleware-cookies';
import { SessionCache, Session } from './session/';
import Session from './session/session';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MW was importing get-access-token.ts in it's binary, which it doesn't need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants