Add logout options #877
Merged
Add logout options #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Widcket
reviewed
Oct 21, 2022
| * @example pass the federated logout param per https://auth0.com/docs/authenticate/login/logout/log-users-out-of-idps | ||
| * | ||
| * ```js | ||
| * handleLogout(req, res, { logoutParams: { federated: '' } }); |
There was a problem hiding this comment.
Shouldn't it be federated: true instead of an empty string?
There was a problem hiding this comment.
federated=true would work, but Auth0 asks for https://YOUR_DOMAIN/v2/logout?federated - in its docs and this is a closer approximation (which also works)
There was a problem hiding this comment.
$ node -e "foo=new URL('https://YOUR_DOMAIN/v2/logout'); foo.searchParams.set('federated', ''); console.log(foo.toString())"
https://your_domain/v2/logout?federated=
Widcket
approved these changes
Oct 21, 2022
6 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
For example, to pass the federated logout param per https://auth0.com/docs/authenticate/login/logout/log-users-out-of-idps
📎 References
fixes #842