Add default to PageRoute type parameter #632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add default to PageRoute type parameter to match the default for the WithPageAuthRequiredOptions type and make it easier for the generic type to be used.
The generic type arguments for URL queries were added here: #554 and these changes were released in v1.7.0.
For codebases that were already importing the PageRoute type, the introduction of the new required type argument failed type-checking with this error:
It is easily fixed by providing a value for the new type argument, but by adding the default into this package it makes it easier for users of the package since they do not have to update their codebases.
Testing
Since this is a modification of the type definition, no tests have been added.
Checklist
main